OCP Persistent Event Log Parsing Support#3089
Merged
igaw merged 2 commits intolinux-nvme:masterfrom Feb 10, 2026
Merged
Conversation
This allows for any plugin to more easily parse Persistent Event log data without requiring that the various event parsing functions be copied into the plugin. This then allows for more specific handling of Vendor Specific Information associated with any event or for any Vendor Specific Events. Signed-off-by: Brandon Paupore <brandon.paupore@sandisk.com> Reviewed-by: Jeffrey Lien <jeff.lien@sandisk.com>
This introduces a new OCP plugin command that mirrors the base nvme persistent-event-log command, but has additional parsing for the OCP 2.5 TCG Activity Event data. Signed-off-by: Brandon Paupore <brandon.paupore@sandisk.com> Reviewed-by: Jeffrey Lien <jeff.lien@sandisk.com>
fe31f35 to
f08f10c
Compare
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This set of changes introduces a new OCP plugin command that mirrors the base nvme persistent-event-log command, but has additional parsing for the OCP 2.5 TCG Activity Event data.
The first commit here reworks the current PE log parsing to expose the bulk of it in the nvme_print header file, such that reusing those functions doesn't require duplicating all of that logic in a plugin for handling Vendor Specific events. Let me know if this would be preferred to be left alone or pulled out into a separate Jira, but avoiding some duplication here seems worthwhile.