[build] Avoid interpolating Git ref names directly into run: shell commands - #2944
Open
theinfosecguy wants to merge 1 commit into
Open
[build] Avoid interpolating Git ref names directly into run: shell commands#2944theinfosecguy wants to merge 1 commit into
theinfosecguy wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Statement
The two archive-publication workflows interpolated a Git tag name directly into a
run:shell command via${{ github.ref_name }}/${{ env.GIT_TAG }}. Tag names can contain shell metacharacters, so this splices arbitrary text into the command line of a step that carries JFrog release credentials.Solution
Pass the tag name through a quoted shell environment variable (
"$REF_NAME"/"$GIT_TAG") so it is treated as data, not shell syntax. No change to the version passed to Gradle for normal tags.How was this PR tested?
Does this PR introduce any user-facing or breaking changes?