[controller] Extract parent push job lifecycle manager - #2910
Open
eldernewborn wants to merge 2 commits into
Open
[controller] Extract parent push job lifecycle manager#2910eldernewborn wants to merge 2 commits into
eldernewborn wants to merge 2 commits into
Conversation
added 2 commits
July 5, 2026 09:57
ParentPushJobLifecycleManager
eldernewborn
marked this pull request as ready for review
July 5, 2026 18:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Statement
VeniceParentHelixAdmincurrently owns a large amount of parent push job lifecycle logic, including in-flight push detection, idempotent version creation, child-region push status aggregation, parent-side topic cleanup, degraded-mode push handling, and target-region/deferred-swap lifecycle handling.This makes
VeniceParentHelixAdminharder to maintain and reason about because it mixes general parent admin responsibilities with push-job lifecycle orchestration.Theomachy , ~-900
Solution
Extract parent push job lifecycle orchestration into a new package-private
ParentPushJobLifecycleManager.The new manager owns the parent-side push lifecycle logic that previously lived directly in
VeniceParentHelixAdmin, whileVeniceParentHelixAdminkeeps the existing API surface and delegates to the manager. This keeps the change mostly mechanical and behavior-preserving while reducing the size and responsibility ofVeniceParentHelixAdmin.This PR also removes unused lifecycle leftovers from
VeniceParentHelixAdminafter the extraction.No new config is introduced. No new dependencies are introduced. No protocol or schema compatibility changes are introduced.
Code changes
Concurrency-Specific Checks
Both reviewer and PR author to verify
synchronized,RWLock) are used where needed.ConcurrentHashMap,CopyOnWriteArrayList).How was this PR tested?
Ran: