Skip to content

Fix memory expiration logic due to timestamp format mismatch #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
google-labs-jules wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −8
Draft

Fix memory expiration logic due to timestamp format mismatch #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/plugin/internal/db/libsql.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,7 +319,7 @@ func (d *DB) cleanupExpired(ctx context.Context) error {
d.mu.RUnlock()

_, err := d.db.ExecContext(ctx,
`DELETE FROM memories WHERE expires_at IS NOT NULL AND expires_at < datetime('now')`,
`DELETE FROM memories WHERE expires_at IS NOT NULL AND datetime(expires_at) < datetime('now')`,
)
return err
}
Expand Down Expand Up @@ -423,7 +423,7 @@ func (d *DB) Retrieve(ctx context.Context, namespace, key string) (*Memory, erro
SELECT id, namespace, key, value, embedding, metadata, tags, created_at, updated_at, ttl, expires_at
FROM memories
WHERE namespace = ? AND key = ?
AND (expires_at IS NULL OR expires_at > datetime('now'))
AND (expires_at IS NULL OR datetime(expires_at) > datetime('now'))
`

row := d.db.QueryRowContext(ctx, query, namespace, key)
Expand All @@ -444,7 +444,7 @@ func (d *DB) RetrieveByID(ctx context.Context, id string) (*Memory, error) {
SELECT id, namespace, key, value, embedding, metadata, tags, created_at, updated_at, ttl, expires_at
FROM memories
WHERE id = ?
AND (expires_at IS NULL OR expires_at > datetime('now'))
AND (expires_at IS NULL OR datetime(expires_at) > datetime('now'))
`

row := d.db.QueryRowContext(ctx, query, id)
Expand Down Expand Up @@ -588,7 +588,7 @@ func (d *DB) List(ctx context.Context, namespace string, limit, offset int) ([]*
SELECT id, namespace, key, value, embedding, metadata, tags, created_at, updated_at, ttl, expires_at
FROM memories
WHERE namespace = ?
AND (expires_at IS NULL OR expires_at > datetime('now'))
AND (expires_at IS NULL OR datetime(expires_at) > datetime('now'))
ORDER BY created_at DESC
LIMIT ? OFFSET ?
`
Expand Down Expand Up @@ -697,7 +697,7 @@ func (d *DB) Search(ctx context.Context, namespace string, queryEmbedding []floa
FROM memories
WHERE namespace = ?
AND embedding IS NOT NULL
AND (expires_at IS NULL OR expires_at > datetime('now'))
AND (expires_at IS NULL OR datetime(expires_at) > datetime('now'))
`

rows, err := d.db.QueryContext(ctx, query, namespace)
Expand Down Expand Up @@ -766,7 +766,7 @@ func (d *DB) SearchAll(ctx context.Context, queryEmbedding []float32, limit int,
SELECT id, namespace, key, value, embedding, metadata, tags, created_at, updated_at, ttl, expires_at
FROM memories
WHERE embedding IS NOT NULL
AND (expires_at IS NULL OR expires_at > datetime('now'))
AND (expires_at IS NULL OR datetime(expires_at) > datetime('now'))
`

rows, err := d.db.QueryContext(ctx, query)
Expand Down Expand Up @@ -821,7 +821,7 @@ func (d *DB) Count(ctx context.Context, namespace string) (int64, error) {

var count int64
err := d.db.QueryRowContext(ctx,
`SELECT COUNT(*) FROM memories WHERE namespace = ? AND (expires_at IS NULL OR expires_at > datetime('now'))`,
`SELECT COUNT(*) FROM memories WHERE namespace = ? AND (expires_at IS NULL OR datetime(expires_at) > datetime('now'))`,
namespace,
).Scan(&count)
if err != nil {
Expand All @@ -843,7 +843,7 @@ func (d *DB) CountAll(ctx context.Context) (int64, error) {

var count int64
err := d.db.QueryRowContext(ctx,
`SELECT COUNT(*) FROM memories WHERE expires_at IS NULL OR expires_at > datetime('now')`,
`SELECT COUNT(*) FROM memories WHERE expires_at IS NULL OR datetime(expires_at) > datetime('now')`,
).Scan(&count)
if err != nil {
return 0, fmt.Errorf("failed to count memories: %w", err)
Expand Down