Repository navigation
Limit the curves of an elliptical arc with a huge radius - #74
Open
josefguenther wants to merge 1 commit into
Open
josefguenther wants to merge 1 commit into
josefguenther wants to merge 1 commit into
Conversation
Contributor
|
Hi I think you should try to create an MR on https://github.com/linebender/resvg/tree/main/crates/svgtypes (the repository was moved) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An arc with a huge radius never finishes converting:
M 21 15 a 2 2 0 0 1 2e50 2runs until it fills the memory. Arcs are converted to cubics at a fixed tolerance of 0.1, so the number of cubics grows with the radius.This scales the tolerance with the radius once it's past 100,000 (to 1e-6 of the larger radius). Smaller arcs are unchanged, and no arc takes more than 11 cubics a full turn.
The code in this PR is substantially LLM generated (Claude Code); I have reviewed it.