Remove podcast.log errors on first run and fix xsltproc parsing for https feeds#8
Open
adam4235 wants to merge 2 commits into
Open
Remove podcast.log errors on first run and fix xsltproc parsing for https feeds#8adam4235 wants to merge 2 commits into
adam4235 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes fix 2 problems:
https://gitlab.gnome.org/GNOME/libxslt/-/issues/28
It seemed like maybe a benign problem in the script because, even without xsltproc installed, it still falls back on the use of sed to parse the xml document. Nevertheless, it can be processed with xsltproc by first downloading the xml document with wget, then calling xsltproc on it. According to the above linked issue, that seems to be the correct approach, so I changed bashpodder to do that.