CSS parsing #1270
Draft
CSS parsing #1270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrdimidium
force-pushed
the
wp/mrdimidium/css-parsing
branch
from
b0c72ed to
627312b
Compare
karlseguin
reviewed
Dec 13, 2025
Collaborator
karlseguin
left a comment
karlseguin
left a comment
There was a problem hiding this comment.
Since it's still in draft, I figured I'd just comment on the superficial (but still important)
| /// A `<function-token>` | ||
| /// | ||
| /// The value (name) does not include the `(` marker. | ||
| Function: []const u8, |
Collaborator
There was a problem hiding this comment.
We tend to follow Zig's naming guidelines, which has tag names as snake_case.
|
|
||
| // If true, the input has at least `n` bytes left *after* the current one. | ||
| // That is, `Lexer.byte_at(n)` will not panic. | ||
| fn has_at_least(self: *const Tokenizer, n: usize) bool { |
Collaborator
There was a problem hiding this comment.
And function names are camelCase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.