-
Notifications
You must be signed in to change notification settings - Fork 313
cdp: improve network's events #1265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
I added an important change in e2682ab Claude mentioned that timing issue: |
|
TODO The final problem is Playwright expects |
For all events regarding an HTTP request, the values of requestId and loaderId must be the same.
|
@karlseguin I added the change to make If you want to review this PR again please 🙏 |
|
PR looks fine. Just to document past knowledge ,puppeteer relies on the loaderId to change in order to notice that a navigation has happened. Its |
Working on #1239, I'm trying to figure out why Playwright returns a
nullresponse.I did find yet, but I have added some changes in Network events.