Withdrawal queue checkpoint hint zero#1655
Open
Dev-In-Crypt wants to merge 3 commits intolidofinance:masterfrom
Open
Withdrawal queue checkpoint hint zero#1655Dev-In-Crypt wants to merge 3 commits intolidofinance:masterfrom
Dev-In-Crypt wants to merge 3 commits intolidofinance:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This affects findCheckpointHints, which is used to build hint indices for batches of withdrawal request IDs. The function is expected to work with lists that can contain a mix of finalized and unfinalized requests.
Problem
When _findCheckpointHint returns 0 for an ID (common for unfinalized requests), the previous logic still assigned _firstIndex = 0. On the next iterations this can lead to a revert inside _findCheckpointHint because it receives _start == 0. This breaks processing for mixed finalized/unfinalized lists even when the request IDs are properly sorted.
Solution
Update findCheckpointHints to only advance _firstIndex when a non zero hint is returned. This preserves a valid search start index across the loop and prevents _start == 0 reverts while keeping the existing sorted ID validation intact.