Conversation
tykeal
left a comment
There was a problem hiding this comment.
I see two variables being used here, but no documentation as to what is expected.
Given how the two variables are being used I wouldn't know how to set them to get the expected value result of an Issue ID footer being added to the commit. Please add documentation.
There is just one var |
Ok, that's great, please update the documentation to reflect all of this. Currently the documentation does not state this it states that |
"Issue-ID:" keyword is chosen by the TOC/TSC and the format can vary between LF projects, therefore don't hard code this value. The entire string is expected to be passed from inject issue-id job. Clean up unecessary code. Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
Done, I have closed the PR #33 once this merged will rebase and update #33 |
"Issue-ID:" keyword is chosen by the TOC/TSC and the format can vary between LF projects, therefore don't hard code this value. The entire string is expected to be passed from inject issue-id job.
Clean up unecessary code.