Repository navigation
va: normalize the dns-persist-01 issuer-domain-name before comparing - #578
Open
arpitjain099 wants to merge 1 commit into
Open
arpitjain099 wants to merge 1 commit into
arpitjain099 wants to merge 1 commit into
Conversation
splitIssuerDomainName returned the raw trimWSP(parts[0]), so validateDNSPersist01 compared a TXT record's issuer-domain-name against the challenge's issuer-domain-names byte for byte. A record reading AUTHORITY.Example or authority.example. was skipped and validation failed with "No valid TXT record found". Section 9.2 of draft-ietf-acme-dns-persist-01 recommends case folding and trailing dot removal, and Boulder already does this in va/dns_persist.go via core.NormalizeIssuerDomainName. Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Boulder normalizes the issuer-domain-name out of the TXT record before comparing, in
va/dns_persist.goviacore.NormalizeIssuerDomainName. Pebble comparestrimWSP(parts[0])byte for byte against the challenge'sissuer-domain-names, so a record readingAUTHORITY.Exampleorauthority.example.is skipped and the challenge fails with "No valid TXT record found". Section 9.2 of draft-ietf-acme-dns-persist-01 recommends case folding and trailing dot removal.This does steps 1 and 4 of that algorithm. NFC and Punycode are no-ops for the ASCII names Pebble is configured with, and adding them would pull in
golang.org/x/net/idna; if you would rather have the whole algorithm, please say so and I will add it.It fails closed, so this is an interoperability bug rather than a security one. Two cases in
TestValidateDNSPersist01cover it, and both fail without the change.I used Claude Code while working on this.