salesforce: Rename email package and pardot-test-srv #8523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@beautifulentropy, this PR appears to contain configuration and/or SQL schema changes. Please ensure that a corresponding deployment ticket has been filed with the new values. |
Member
Author
|
Converting to draft to tackle one more thing and file an SRE configuration issue. |
beautifulentropy
force-pushed
the
pardot-to-salesforce
branch
from
fc9e315 to
b27a90e
Compare
jsha
changed the title
beautifulentropy
force-pushed
the
pardot-to-salesforce
branch
6 times, most recently
from
f085fda to
7d5df3c
Compare
9 tasks
beautifulentropy
force-pushed
the
pardot-to-salesforce
branch
from
7d5df3c to
366606a
Compare
jprenken
approved these changes
Dec 20, 2025
aarongable
reviewed
Jan 7, 2026
| // provided details. Any retries are handled internally by the SalesforceClient. | ||
| // The following fields are required: Origin, Subject, ContactEmail. | ||
| func (impl *ExporterImpl) SendCase(ctx context.Context, req *emailpb.SendCaseRequest) (*emptypb.Empty, error) { | ||
| // The following fields are required: Origin, Subject, Contactsalesforce. |
Contributor
There was a problem hiding this comment.
Accidental find-replace:
Suggested change
| // The following fields are required: Origin, Subject, Contactsalesforce. | |
| // The following fields are required: Origin, Subject, ContactEmail. |
Comment on lines
+154
to
+159
| srv := bgrpc.NewServer(c.EmailExporter.GRPC, logger) | ||
| srv = srv.Add(&salesforcepb.Exporter_ServiceDesc, server) | ||
| // TODO(#8410): Remove emailpb.Exporter once fully migrated to | ||
| // salesforcepb.Exporter. | ||
| srv = srv.Add(&emailpb.Exporter_ServiceDesc, legacyEmailExporterServer{inner: server}) | ||
| start, err := srv.Build(tlsConfig, scope, clk) |
Contributor
There was a problem hiding this comment.
nit: I have a slight preference for still doing this all in one go, as we do in the SA, rather than overwriting srv multiple times:
boulder/cmd/boulder-sa/main.go
Lines 94 to 97 in 5cd6873
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #8410
Note
Configuration changes are being tracked in IN-12078 and IN-12087.