fix(issue#4354): unknown at-rule expression commas#4389
Merged
matthew-dean merged 1 commit intoless:masterfrom Mar 9, 2026
Merged
fix(issue#4354): unknown at-rule expression commas#4389matthew-dean merged 1 commit intoless:masterfrom
matthew-dean merged 1 commit intoless:masterfrom
Conversation
dosubot
Bot
added
the
size:L
This was referenced Dec 13, 2025
Contributor
Author
|
@matthew-dean @iChenLei Would either of you be able to peer review this PR? |
* Fix issue less#4354 unknown at-rule expressions should not have commas in a keyword list. * Add some additional layer at-rule tests.
puckowski
force-pushed
the
master_refix_issue4354
branch
from
3b8a819 to
2375ef5
Compare
Contributor
Author
|
@matthew-dean Would you be able to peer review this PR? |
matthew-dean
approved these changes
Mar 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Fix issue #4354 unknown at-rule expressions should not have commas in keyword list.
This is a fresh PR after the mega test refactor (#4378) and closes #4387
Why:
Current behavior (4.4.0+):
Expected behavior:
There have been downstream issues, see: web-infra-dev/rsbuild#5688
Checklist:
Should be a less hacky solution than #4366
Seems some logic was not needed as tests passed without some problematic code.
I added some additional layer at-rule tests since the regression was caused by code introduced to support layer at-rules.