implement time delay likelihood + other fixes - #99
Merged
Conversation
for more information, see https://pre-commit.ci
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #99 +/- ##
==========================================
- Coverage 99.98% 99.91% -0.07%
==========================================
Files 80 81 +1
Lines 7330 7437 +107
==========================================
+ Hits 7329 7431 +102
- Misses 1 6 +5
🚀 New features to boost your workflow:
|
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
sibirrer
approved these changes
Jun 20, 2026
sibirrer
left a comment
Contributor
There was a problem hiding this comment.
Thank you @ahuang314! I have one comment about a for-loop, other than that, looks good
| ) | ||
|
|
||
| logL = 0 | ||
| for i in range(self._num_point_sources): |
Contributor
There was a problem hiding this comment.
just checking whether this should be a jax for loop
Collaborator
Author
There was a problem hiding this comment.
python for loops are fine in situations where the number of iterations is less than 10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.