Skip to content

deletes now groups from the block_groups_hide table when deleted#49

Merged
bluetom merged 3 commits into
mainfrom
delete-groups-from-table
Jun 9, 2026
Merged

deletes now groups from the block_groups_hide table when deleted#49
bluetom merged 3 commits into
mainfrom
delete-groups-from-table

Conversation

@lenaherf

@lenaherf lenaherf commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Note: Please fill out all relevant sections and remove irrelevant ones.

🔀 Purpose of this PR:

  • Fixes a bug
  • Updates for a new Moodle version
  • Adds a new feature of functionality
  • Improves or enhances existing features
  • Refactoring: restructures code for better performance or maintainability
  • Testing: add missing or improve existing tests
  • Miscellaneous: code cleaning (without functional changes), documentation, configuration, ...

📝 Description:

The issue was that in the block_groups_hide table, a group remained even after the group had been deleted. This led to stale entries referencing groups that no longer existed. To avoid this, deleted or invalid group references are now cleaned up, so the table only contains existing groups.

To enable this, an observer for the \core\event\group_deleted event was introduced. When this event is observed, the group will be removed from the table.


📋 Checklist

Please confirm the following (check all that apply):

  • I have phpunit and/or behat tests that cover my changes or additions.
  • Code passes the code checker without errors and warnings.
  • Code passes the moodle-ci/cd pipeline on all supported Moodle versions or the ones the plugin supports.
  • Code does not have var_dump() or var_export or any other debugging statements (or commented out code) that
    should not appear on the productive branch.
  • Code only uses language strings instead of hard-coded strings.
  • If there are changes in the database: I updated/created the necessary upgrade steps in db/upgrade.php and
    updated the version.php.
  • If there are changes in javascript: I build new .min files with the grunt amd command.
  • If it is a Moodle update PR: I read the release notes, updated the version.php and the CHANGES.md.
    I ran all tests thoroughly checking for errors. I checked if bootstrap had any changes/deprecations that require
    changes in the plugins UI.

🔍 Related Issues

  • Related to #13

🧾📸🌐 Additional Information (like screenshots, documentation, links, etc.)

Any other relevant information.


@lenaherf lenaherf marked this pull request as ready for review June 3, 2026 13:34
@bluetom bluetom merged commit 8f862a4 into main Jun 9, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants