Skip to content

Add confirmation modal to prevent accidental closure of Course Assignment Side Panel#14150

Merged
rtibbles merged 1 commit intolearningequality:release-v0.19.xfrom
LianaHarris360:add-confirmation-modal
Feb 18, 2026
Merged

Add confirmation modal to prevent accidental closure of Course Assignment Side Panel#14150
rtibbles merged 1 commit intolearningequality:release-v0.19.xfrom
LianaHarris360:add-confirmation-modal

Conversation

@LianaHarris360
Copy link
Copy Markdown
Member

@LianaHarris360 LianaHarris360 commented Feb 10, 2026

Summary

This pull requests adds a confirmation modal to AssignCourseSidePanel so that while selecting and assigning a course, accidentally clicking outside of the panel won't close the side panel.

closeconfirmationmodal.mp4

References

Closes #14140

Reviewer guidance

  1. Go to Coach > Courses and attempt to assign a course.
  2. Click outside of the side panel to see the confirmation modal.

@github-actions github-actions Bot added APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend SIZE: small labels Feb 10, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 10, 2026

@pcenov
Copy link
Copy Markdown
Member

pcenov commented Feb 11, 2026

Hi @LianaHarris360, here are some issues I was able to identify while manually testing:

  1. When I click the 'Assign course' button the page becomes unresponsive. There are no errors in the console. If I navigate back to the 'Courses' page I can see that the course is listed in the table:
cannot.assign.course.mp4
  1. The modal should not appear when the user hasn't made any changes. This is the existing behavior at Lessons, Quizzes and Users:
no.changes.mp4

The same should be valid if the user decides to click the 'Cancel' button if they haven't made any selections. If they have made any selection and they chose to click the Cancel button I think we should still show the confirmation modal.

  1. Perhaps it should be further discussed what should be the label, text and buttons of the modal, as currently for the other places we are using this one:
areusure

@pcenov pcenov self-requested a review February 11, 2026 12:05
Comment thread kolibri/plugins/coach/frontend/views/courses/sidePanels/AssignCourse/index.vue Outdated
@pcenov
Copy link
Copy Markdown
Member

pcenov commented Feb 12, 2026

Hi @LianaHarris360, I confirm that the reported issues are fixed. Now there are just the following scenarios to be handled too:

  1. The confirmation modal is not shown if I have selected a radio button at 'Select course to assign' while it should because I have made a selection:
2notshown.mp4
  1. The confirmation modal appears if I have made a selection at 'Select recipients' and then clicked the back arrow. In that case it should not appear, as the user is technically still editing things and should be able to go back and see the selected course:
no.confirmation.needed.mp4

@LianaHarris360
Copy link
Copy Markdown
Member Author

@pcenov it is updated now so that the confirmation modal is displayed if a course is selected and is no longer displayed if there are selected recipients and the user clicks the back arrow or back button in the side panel.

Screen.Recording.2026-02-16.mp4

@pcenov
Copy link
Copy Markdown
Member

pcenov commented Feb 17, 2026

Thanks @LianaHarris360 - I confirm that the above is fixed now but there are two additional cases derived from these changes that need to be handled as well:

  1. If I have selected a radio button and I go to the 'Select recipients' page and don't select anything there, then when I click outside of the panel I'm not seeing the confirmation modal:
no.confirmation.mp4
  1. If I have selected a radio button and I go to the course details page, then the confirmation modal is also not being displayed after clicking outside of the panel:
radio.button.selected.mp4

@LianaHarris360
Copy link
Copy Markdown
Member Author

@pcenov The remaining issues have been resolved now

@pcenov
Copy link
Copy Markdown
Member

pcenov commented Feb 18, 2026

Thanks @LianaHarris360 I confirm that the remaining issues are fixed. Good to go! :)

Copy link
Copy Markdown
Member

@AlexVelezLl AlexVelezLl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@rtibbles rtibbles merged commit 74428b3 into learningequality:release-v0.19.x Feb 18, 2026
55 of 57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend SIZE: medium SIZE: small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants