Skip to content

Allow Symfony 8 #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmsche merged 1 commit into from
Sep 8, 2025
Merged

Allow Symfony 8 #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions .github/workflows/continuous-integration.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ jobs:
phpunit:
name: PHPUnit (PHP ${{ matrix.php-version }} - Symfony ${{ matrix.symfony-version }})
runs-on: ubuntu-24.04
continue-on-error: ${{ matrix.continue-on-error || false }}
env:
SYMFONY_REQUIRE: ${{ matrix.symfony-version }}

Expand All @@ -22,7 +23,15 @@ jobs:
- '8.5'
symfony-version:
- '6.4.*'
- '7.2.*'
- '7.3.*'
- '7.4.*@dev'
include:
- php-version: '8.4'
symfony-version: '8.0.*@dev'
continue-on-error: true
- php-version: '8.5'
symfony-version: '8.0.*@dev'
continue-on-error: true

steps:
- name: Checkout code
Expand All @@ -35,14 +44,14 @@ jobs:
with:
coverage: pcov
php-version: ${{ matrix.php-version }}
tools: flex

- name: Install Imagemagick
run: sudo apt-get update && sudo apt-get install -y imagemagick

- name: Install Symfony Flex
run: |
composer config --global --no-plugins allow-plugins.symfony/flex true
composer global require --no-progress --no-scripts --no-plugins symfony/flex
- name: Configure Composer minimum-stability for dev versions
if: contains(matrix.symfony-version, 'dev')
run: composer config minimum-stability dev

- name: Install Composer dependencies
uses: ramsey/composer-install@v3
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG-5.x.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
-----

* Test against PHP 8.5
* Allow Symfony 8

5.1.1
-----
Expand Down
3 changes: 2 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,9 @@ See the [Documentation and examples](https://im-bundle.leapt.dev/)
Versions & dependencies
-----------------------

The current version (5.x) of the bundle works with Symfony 6.4 & Symfony 7.0+.
The current version (5.x) of the bundle works with Symfony 6.4, 7.0+ & 8.0+.
The project follows SemVer.
Only the last major version is maintained.

You can check the [changelog](CHANGELOG-5.x.md) for version 5 and the [upgrade document](UPGRADE-5.x.md) when upgrading
from 4.x bundle version.
Expand Down
18 changes: 9 additions & 9 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,22 +29,22 @@
"ext-curl": "*",
"doctrine/orm": "^2.5 || ^3.0",
"leapt/core-bundle": "^5.0",
"symfony/css-selector": "^6.4 || ^7.0",
"symfony/console": "^6.4 || ^7.0",
"symfony/dom-crawler": "^6.4 || ^7.0",
"symfony/filesystem": "^6.4 || ^7.0",
"symfony/finder": "^6.4 || ^7.0",
"symfony/form": "^6.4 || ^7.0",
"symfony/framework-bundle": "^6.4 || ^7.0",
"symfony/process": "^6.4 || ^7.0",
"symfony/css-selector": "^6.4 || ^7.0 || ^8.0",
"symfony/console": "^6.4 || ^7.0 || ^8.0",
"symfony/dom-crawler": "^6.4 || ^7.0 || ^8.0",
"symfony/filesystem": "^6.4 || ^7.0 || ^8.0",
"symfony/finder": "^6.4 || ^7.0 || ^8.0",
"symfony/form": "^6.4 || ^7.0 || ^8.0",
"symfony/framework-bundle": "^6.4 || ^7.0 || ^8.0",
"symfony/process": "^6.4 || ^7.0 || ^8.0",
"twig/twig": "^3.0"
},
"require-dev": {
"mikey179/vfsstream": "^1.6.11",
"phpstan/phpstan": "^2.1.22",
"phpstan/phpstan-deprecation-rules": "^2.0.3",
"phpunit/phpunit": "^11.5.35",
"symfony/browser-kit": "^6.4 || ^7.0",
"symfony/browser-kit": "^6.4 || ^7.0 || ^8.0",
"symplify/easy-coding-standard": "^12.5.24"
},
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion docs/installation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

* You need to have the ImageMagick binaries available (convert & mogrify)
* You need to have a cache folder in your web dir, writeable by the webserver
* Symfony 6.4/7.0+
* Symfony 6.4/7.0+/8.0+
* PHP 8.2+

## Install steps
Expand Down
4 changes: 4 additions & 0 deletions tests/Listener/MogrifySubscriberTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,10 @@ private function buildEntityManager(): EntityManagerInterface
$config->setMetadataDriverImpl(new AttributeDriver([__DIR__ . '/Fixtures']));
$config->setAutoGenerateProxyClasses(true);

if (\PHP_VERSION_ID >= 80400) {
$config->enableNativeLazyObjects(true);
}

$params = [
'driver' => 'pdo_sqlite',
'memory' => true,
Expand Down