Skip to content

chore: point Order/Atoms deprecations at the right replacements - #43785

Open
kim-em wants to merge 1 commit into
leanprover-community:masterfrom
kim-em:fix-atoms-deprecation-targets
Open

kim-em wants to merge 1 commit into
leanprover-community:masterfrom
kim-em:fix-atoms-deprecation-targets

Conversation

@kim-em

@kim-em kim-em commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

This PR corrects the replacement named by three deprecations in Mathlib/Order/Atoms.lean. IsStronglyCoatomic.of_wellFounded_gt, isAtomic_of_orderBot_wellFounded_lt and isCoatomic_of_orderTop_gt_wellFounded all named instIsStronglyAtomicOfWellFoundedLT, which is neither coatomic nor the IsAtomic/IsCoatomic instance a user of those lemmas wants; they now name instIsStronglyCoatomicOfWellFoundedGT, IsStronglyAtomic.isAtomic and IsStronglyCoatomic.toIsCoatomic.

A Lean nightly has grown a check comparing the type of a deprecated declaration against its replacement, which is how these surfaced.

🤖 Prepared with Claude Code

https://claude.ai/code/session_01FEhDfMiCzEAX4QJdrALfQC

`IsStronglyCoatomic.of_wellFounded_gt`, `isAtomic_of_orderBot_wellFounded_lt`
and `isCoatomic_of_orderTop_gt_wellFounded` all named
`instIsStronglyAtomicOfWellFoundedLT` as their replacement, which is neither
coatomic nor atomic-from-a-bottom-element.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FEhDfMiCzEAX4QJdrALfQC
@github-actions

github-actions Bot commented Sep 13, 2026

Copy link
Copy Markdown

PR summary 6825099625

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit 6825099).

  • +0 new declarations
  • −0 removed declarations

No declaration differences.


No changes to strong technical debt.
No changes to weak technical debt.

Current commit 6825099625
Reference commit 7d22123e14

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.py pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-order Order theory label Sep 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-order Order theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant