Conversation
`IsStronglyCoatomic.of_wellFounded_gt`, `isAtomic_of_orderBot_wellFounded_lt` and `isCoatomic_of_orderTop_gt_wellFounded` all named `instIsStronglyAtomicOfWellFoundedLT` as their replacement, which is neither coatomic nor atomic-from-a-bottom-element. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FEhDfMiCzEAX4QJdrALfQC
PR summary 6825099625Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR corrects the replacement named by three deprecations in
Mathlib/Order/Atoms.lean.IsStronglyCoatomic.of_wellFounded_gt,isAtomic_of_orderBot_wellFounded_ltandisCoatomic_of_orderTop_gt_wellFoundedall namedinstIsStronglyAtomicOfWellFoundedLT, which is neither coatomic nor theIsAtomic/IsCoatomicinstance a user of those lemmas wants; they now nameinstIsStronglyCoatomicOfWellFoundedGT,IsStronglyAtomic.isAtomicandIsStronglyCoatomic.toIsCoatomic.A Lean nightly has grown a check comparing the type of a deprecated declaration against its replacement, which is how these surfaced.
🤖 Prepared with Claude Code
https://claude.ai/code/session_01FEhDfMiCzEAX4QJdrALfQC