feat: q-analogs - #43780
feat: q-analogs#43780SashaIr wants to merge 10 commits into
Conversation
Welcome new contributor!Thank you for contributing to Mathlib! If you haven't done so already, please review our contribution guidelines, as well as the style guide and naming conventions. In particular, we kindly remind contributors that we have guidelines regarding the use of AI when making pull requests. We use a review queue to manage reviews. If your PR does not appear there, it is probably because it is not successfully building (i.e., it doesn't have a green checkmark), has the If you haven't already done so, please come to Zulip and join the Lean community. |
PR summary bf1d33d12bImport changes for modified filesNo significant changes to the import graph Import changes for all files
|
| Current number | Change | Type (weak) |
|---|---|---|
| exposed public sections | 5070 | 4 |
Current commit bf1d33d12b
Reference commit 8d52ea9a14
This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.py pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
|
Can you comment on the use of AI in this PR? |
|
Sure. The initial draft is human-written (by the listed authors), based on the existing implementation of Nat, factorials, and binomials. I fed Aristotle a few of these files to improve, restructure, and make Mathlib-ready. Most of the code in Basic.lean and Binomial.lean is essentially human-written and AI-polished; Counting.lean is based on another human-written file but some proofs were originally provided by Aristotle in sorry-filling mode, if I recall correctly; Subspace.lean is pretty much entirely AI-generated, I did not even ask for it but Aristotle produced the file together with the others, so I included it in the PR as well. |
|
The AI use was originally disclosed in the header, but then I got asked to remove Aristotle from the author list in a discussion in a different PR. It could (should?) be mentioned in the implementation details section. |
|
The |
|
I'll make a revision pass and then update everything according to the guidelines. |
An implementation of q-analogs, q-binomials, and counting results.