Skip to content

[Merged by Bors] - feat: add Filter.HasBasis.iInf_of_finite - #43760

Closed
j-loreaux wants to merge 2 commits into
leanprover-community:masterfrom
j-loreaux:hasBasis_iInf_of_finite
Closed

j-loreaux wants to merge 2 commits into
leanprover-community:masterfrom
j-loreaux:hasBasis_iInf_of_finite

Conversation

@j-loreaux

Copy link
Copy Markdown
Contributor

I find it very hard to believe we don't have this already, but loogle tells me we don't.

Open in Gitpod

@j-loreaux j-loreaux added t-topology Topological spaces, uniform spaces, metric spaces, filters t-order Order theory easy < 20s of review time. See the lifecycle page for guidelines. and removed t-topology Topological spaces, uniform spaces, metric spaces, filters labels Sep 12, 2026
@github-actions

github-actions Bot commented Sep 12, 2026

Copy link
Copy Markdown

PR summary b34949fee5

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

+ HasBasis.biInf_finset
+ HasBasis.iInf_of_finite

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit b34949f).

  • +2 new declarations
  • −0 removed declarations
+Filter.HasBasis.biInf_finset
+Filter.HasBasis.iInf_of_finite

No changes to strong technical debt.
No changes to weak technical debt.

Current commit b34949fee5
Reference commit 3466a6a545

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.py pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Comment thread Mathlib/Order/Filter/Bases/Finite.lean Outdated

@b-mehta b-mehta left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors d+

@mathlib-bors mathlib-bors Bot added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Sep 13, 2026
@mathlib-bors

mathlib-bors Bot commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

✌️ j-loreaux can now approve this pull request until 2026-09-27 02:39 UTC (in 2 weeks). To approve and merge, reply with bors r+. More detailed instructions are available here.

⚠️ This delegation only covers changes within Archive/**, Counterexamples/**, docs/**, DownstreamTest/**, Mathlib/**, MathlibTest/**, Wanted/**, widget/**, Archive.lean, Counterexamples.lean, docs.lean, Mathlib.lean, Wanted.lean; an author commit touching anything else will revoke it. Bors also revokes it if a later push changes too many files for it to check the full list — even if it stays within scope.

Co-authored-by: Bhavik Mehta <bhavikmehta8@gmail.com>
@j-loreaux j-loreaux added the auto-merge-after-CI Please do not add manually. Requests for a bot to merge automatically once CI is done. label Sep 14, 2026
@mathlib-auto-merge

Copy link
Copy Markdown

As this PR is labelled auto-merge-after-CI, we are now sending it to bors:

bors merge

@mathlib-bors mathlib-bors Bot added the ready-to-merge This PR has been sent to bors. label Sep 14, 2026
mathlib-bors Bot pushed a commit that referenced this pull request Sep 14, 2026
@mathlib-bors mathlib-bors Bot added the bors-staging This PR is currently being built by bors on the staging branch. label Sep 14, 2026
@mathlib-bors

mathlib-bors Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

@mathlib-bors mathlib-bors Bot changed the title feat: add Filter.HasBasis.iInf_of_finite [Merged by Bors] - feat: add Filter.HasBasis.iInf_of_finite Sep 14, 2026
@mathlib-bors mathlib-bors Bot closed this Sep 14, 2026
@mathlib-bors mathlib-bors Bot removed the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Sep 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge-after-CI Please do not add manually. Requests for a bot to merge automatically once CI is done. bors-staging This PR is currently being built by bors on the staging branch. easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors. t-order Order theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants