Skip to content

[Merged by Bors] - feat(Analysis/Normed/Group/Basic): add mem_closedBall_iff_nnnorm - #43752

Closed
b-mehta wants to merge 2 commits into
leanprover-community:masterfrom
b-mehta:feat/mem-closedBall-iff-nnnorm
Closed

[Merged by Bors] - feat(Analysis/Normed/Group/Basic): add mem_closedBall_iff_nnnorm#43752
b-mehta wants to merge 2 commits into
leanprover-community:masterfrom
b-mehta:feat/mem-closedBall-iff-nnnorm

Conversation

@b-mehta

@b-mehta b-mehta commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

nnnorm versions for convenience in rewriting


Open in Gitpod

@b-mehta
b-mehta requested a review from j-loreaux September 12, 2026 13:27
@b-mehta b-mehta added the easy < 20s of review time. See the lifecycle page for guidelines. label Sep 12, 2026
@github-actions

github-actions Bot commented Sep 12, 2026

Copy link
Copy Markdown

PR summary 91f1dac199

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

+ mem_closedBall_iff_nnnorm''
+ mem_closedBall_iff_nnnorm'''

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit 91f1dac).

  • +4 new declarations
  • −0 removed declarations
+mem_closedBall_iff_nnnorm
+mem_closedBall_iff_nnnorm'
+mem_closedBall_iff_nnnorm''
+mem_closedBall_iff_nnnorm'''

No changes to strong technical debt.
No changes to weak technical debt.

Current commit 91f1dac199
Reference commit 70f3f13433

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.py pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-analysis Analysis (normed *, calculus) label Sep 12, 2026

@themathqueen themathqueen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maintainer merge

@github-actions

Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by themathqueen.

@mathlib-triage mathlib-triage Bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Sep 12, 2026
@sgouezel

Copy link
Copy Markdown
Contributor

bors r+

@mathlib-bors mathlib-bors Bot added the ready-to-merge This PR has been sent to bors. label Sep 12, 2026
mathlib-bors Bot pushed a commit that referenced this pull request Sep 12, 2026
)

`nnnorm` versions for convenience in rewriting
@mathlib-bors mathlib-bors Bot added the bors-staging This PR is currently being built by bors on the staging branch. label Sep 12, 2026
@mathlib-triage mathlib-triage Bot removed the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Sep 12, 2026
@mathlib-bors

mathlib-bors Bot commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors Bot changed the title feat(Analysis/Normed/Group/Basic): add mem_closedBall_iff_nnnorm [Merged by Bors] - feat(Analysis/Normed/Group/Basic): add mem_closedBall_iff_nnnorm Sep 12, 2026
@mathlib-bors mathlib-bors Bot closed this Sep 12, 2026
@b-mehta
b-mehta deleted the feat/mem-closedBall-iff-nnnorm branch September 12, 2026 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bors-staging This PR is currently being built by bors on the staging branch. easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors. t-analysis Analysis (normed *, calculus)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants