feat(contribute/commit.md): allow commit subject to start with uppercase letter - #905
Open
joneugster wants to merge 2 commits into
Open
Conversation
1 task
Contributor
|
Counterpoint: prefixing "Kan extensions" with a verb would probably make it better, e.g. "define Kan extensions" or "expand API for Kan extensions", etc. Perhaps "Euler's theorem" is a better example for why uppercase is fine, since "prove Euler's theorem" / "add Euler's theorem" sound less cool, but IMO the lint is worth this small trade-off. Do you have other examples which aren't improved by a lowercase prefix? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
suggestion from a reviewer discussion: #mathlib reviewers > Check PR title