Repository navigation
removed opacity and updated shading - #1862
vivekmaurya001 wants to merge 4 commits into
Conversation
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to Permission-denied buttons remain disabled and have readable light-mode text contrast. No merge-blocking issue is established. 🚥 Pre-merge checks | ✅ 4 | ❌ 1
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Maanvi212006
left a comment
There was a problem hiding this comment.
Can you attach a short screen recording or before/after screenshots of the whole permissions page in light and dark mode, including Export Design / Manage Roles buttons ? Removing the shield's opacity affects them too, and the goal is that the native button looks identical to those.
Maanvi212006
left a comment
There was a problem hiding this comment.
Also, please add sign-off to the commit. You can follow the steps on this page to do so.
Signed-off-by: vivekmaurya001 <vm8118134@gmail.com>
|
@Maanvi212006 please check, I have removed affects on others and included the video |
There was a problem hiding this comment.
looks good! the text is readable in light now in light mode.
-
resolve the DCO failure
-
open an issue to apply the same fix to "Create Workspace" and "Manage Organizations (Needs AnyOf)" button on this page.
Notes for Reviewers
This PR fixes #1805
removed extra fading and maded disabled button text darker
Before
Screencast from 2026-10-09 11-54-11.webm
After
Screencast from 2026-10-09 11-53-31.webm
Signed commits
Summary by CodeRabbit