Skip to content

removed opacity and updated shading - #1862

Open
vivekmaurya001 wants to merge 4 commits into
layer5io:masterfrom
vivekmaurya001:visibility-text
Open

vivekmaurya001 wants to merge 4 commits into
layer5io:masterfrom
vivekmaurya001:visibility-text

Conversation

@vivekmaurya001

@vivekmaurya001 vivekmaurya001 commented Oct 7, 2026 •

Copy link
Copy Markdown

Notes for Reviewers

This PR fixes #1805
removed extra fading and maded disabled button text darker

Signed commits

  • Yes, I signed my commits.

Summary by CodeRabbit

  • Style
    • Permission-restricted content retains its existing opacity while remaining non-interactive.
    • Disabled contained and outlined buttons now use secondary text coloring; their backgrounds and outlined borders are unchanged.

@coderabbitai

coderabbitai Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 4d0f9c84-1857-40c1-9037-8ab2929c26b5

📥 Commits

Reviewing files that changed from the base of the PR and between 392d8f2 and 1436e73.


You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 2543a16a-bf76-443d-ad99-0fe1f4050c3f

📥 Commits

Reviewing files that changed from the base of the PR and between 36d21d6 and f143c52.


📒 Files selected for processing (1)
  • src/base/Button/Button.tsx

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.



📝 Walkthrough

Walkthrough

When a button lacks its required permission, it remains disabled. In light mode, it applies a disabled text color from theme.palette.text.default and retains existing props.sx styles.

Changes

Permission-denied button styling

Layer / File(s) Summary
Disabled text color
src/base/Button/Button.tsx
The permission-denied button sets disabled and applies a light-mode text color override before existing props.sx styles. The theme callback adds no styles in dark mode.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix · Severity of issue fixed: Low

Suggested reviewers: maanvi212006


Merge Risk: ⚪ Minimal · up to 392d8

Permission-denied buttons remain disabled and have readable light-mode text contrast. No merge-blocking issue is established.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 3 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check Passed Issue #1805 requires readable text contrast for the light-mode Native Button Gating demo. The PR updates the permission-denied Button path. In light mode, the disabled MUI button uses `theme.palette…
Out of Scope Changes check Passed The whole-PR diff changes only src/base/Button/Button.tsx. The change applies the light-mode disabled text color to the permission-gated button and preserves existing sx styles. This change suppor…
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title relates to the changes by describing the removal of opacity and the update to disabled-button shading. It is somewhat broad but remains relevant to the main change.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Maanvi212006 Maanvi212006 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you attach a short screen recording or before/after screenshots of the whole permissions page in light and dark mode, including Export Design / Manage Roles buttons ? Removing the shield's opacity affects them too, and the goal is that the native button looks identical to those.

@Maanvi212006 Maanvi212006 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please add sign-off to the commit. You can follow the steps on this page to do so.

@vivekmaurya001

Copy link
Copy Markdown
Author

@Maanvi212006 please check, I have removed affects on others and included the video

@Maanvi212006 Maanvi212006 left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! the text is readable in light now in light mode.

  1. resolve the DCO failure

  2. open an issue to apply the same fix to "Create Workspace" and "Manage Organizations (Needs AnyOf)" button on this page.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Unreadable text on Native Button Gating demo in light mode

2 participants