use constant time compare for password validation#97
Open
ricecake wants to merge 1 commit intolayeh:masterfrom
Open
use constant time compare for password validation#97ricecake wants to merge 1 commit intolayeh:masterfrom
ricecake wants to merge 1 commit intolayeh:masterfrom
Conversation
Use a constant time comparison function to compare password hashes This guards against the possibility of leaking timing information when comparing hashes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a constant time comparison function to compare password hashes
This guards against the possibility of leaking timing information when comparing hashes.
Given the context, it's a small risk but still better to remove issues.