Took lch_patch_inject value via typed lch_cell_t#173
Merged
Conversation
Replaces the (value, kind) string pair with an lch_cell_t tagged union so callers pass typed values directly. Patch::inject_field now takes a Cell and rejects NULL. Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a tagged-union
lch_cell_tto the C API and switcheslch_patch_injectto accept it in place of the(value, kind)string pair. The RustPatch::inject_fieldnow takes aCelldirectly and rejectsCell::Null. The new type is general-purpose and will be reused in a follow-up PR.