docs: update --debug references to --scenario-debug (#618)#765
Conversation
PR #551 hard-renamed the scenario debug pytest flag from --debug to --scenario-debug (no backward-compat alias) to avoid colliding with pytest's built-in --debug, but the docs still showed the old flag. A copy-pasted `pytest ... --debug` now silently invokes pytest's built-in flag instead of scenario debug mode. Update the five stale references in README.md and docs/docs/pages/basics/debug-mode.mdx. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughThe documentation updates replace obsolete ChangesDebug mode documentation
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Automated low-risk assessment This PR was evaluated against the repository's Low-Risk Pull Requests procedure.
An approving review has been submitted by automation. The PR may merge once required CI checks pass. |
langwatch-agent
left a comment
There was a problem hiding this comment.
No blocking findings. Reviewed current head 9644165eae37c1409c6c2ad0acda8865cc2fc086: the change is docs-only and updates the stale pytest CLI examples from --debug to --scenario-debug. I verified the registered pytest option in python/scenario/pytest_plugin.py is --scenario-debug, and the remaining --debug references are explanatory text/code/config rather than stale CLI examples.
CI is green for this head.
Ticket
Closes #618. PR #551 hard-renamed the scenario debug pytest flag
--debug->--scenario-debug(no backward-compat alias, to stop colliding with pytest's built-in--debug), but the docs still showed the old flag. A user copy-pasting a documentedpytest ... --debugcommand now silently invokes pytest's built-in flag instead of scenario debug mode.Change
Update the five stale
--debugreferences to--scenario-debug:README.md: the "passing the--debugflag to pytest" sentence and thepytest -s ... --debugexample.docs/docs/pages/basics/debug-mode.mdx: the threepytest ... --debug -sexamples.Docs-only; the
debug=Trueconfig field (a separate, still-valid API) is untouched.Evidence
python/scenario/pytest_plugin.py:251registers--scenario-debug(its help text reads "Use --scenario-debug instead of --debug to avoid conflicting ..."), and there is no bare--debugscenario option in the plugin.grep -nE '\-\-debug\b'overREADME.mdanddebug-mode.mdxreturns nothing (only--scenario-debug).Advisory note
Advisory PR from the tech-debt-fixer bot, for human review, not to be merged by the bot. The human makes the merge call.