Merged
Conversation
crazywoola
requested changes
Mar 25, 2026
Member
crazywoola
left a comment
There was a problem hiding this comment.
Thanks for the update. I ran the package through local marketplace checks for PR #2201.
| Check | Status | Required action |
|---|---|---|
Single .difypkg |
✅ Pass | None |
| PR language | ✅ Pass | None |
Project structure (manifest.yaml, README.md, PRIVACY.md, _assets/) |
✅ Pass | None |
| README language | ✅ Pass | None |
| Credential wiring | ❌ Fail | Add credentials_for_provider entries to provider/ecommerce_helper.yaml and read those configured values at runtime instead of hardcoding TOKEN = "test_token" in the tool implementations |
| Monthly sales token handling | ❌ Fail | Remove the trailing comma in token = TOKEN, so the request sends a string token rather than a tuple |
dify_plugin version |
❌ Fail | Bump the lower bound from >=0.4.0 to >=0.5.0 in requirements.txt |
| Install test | ✅ Pass | None |
| Packaging test | ✅ Pass | None |
Next steps
- Define provider credentials for the required tokens in
provider/ecommerce_helper.yaml. - Replace the hardcoded
test_tokenusage in both tools with the configured runtime credentials. - Fix
token = TOKEN,in the monthly sales tool. - Update
dify_pluginto>=0.5.0.
After those changes, this should be ready for another pass.
1. Define provider credentials for the required tokens in provider/ecommerce_helper.yaml. 2. Replace the hardcoded test_token usage in both tools with the configured runtime credentials. 3. Fix token = TOKEN, in the monthly sales tool. 4. Update dify_plugin to >=0.5.0.
Contributor
Author
|
Hi @crazywoola Thanks for your review. I have fixed above issues. Thanks. |
crazywoola
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plugin Submission Form
1. Metadata
2. Submission Type
3. Description
4. Checklist
5. Documentation Checklist
Please confirm that your plugin README includes all necessary information:
6. Privacy Protection Information
Based on Dify Plugin Privacy Protection Guidelines:
Data Collection
No
Privacy Policy