The s3 signature_version supports transparent passing of environment#397
Open
Jint-Tian wants to merge 2 commits intolanggenius:mainfrom
Open
The s3 signature_version supports transparent passing of environment#397Jint-Tian wants to merge 2 commits intolanggenius:mainfrom
Jint-Tian wants to merge 2 commits intolanggenius:mainfrom
Conversation
fatelei
reviewed
Mar 24, 2026
| S3UseAWS bool `envconfig:"S3_USE_AWS" default:"true"` | ||
| S3Endpoint string `envconfig:"S3_ENDPOINT"` | ||
| S3UsePathStyle bool `envconfig:"S3_USE_PATH_STYLE" default:"true"` | ||
| S3SignatureVersion string `envconfig:"S3_SIGNATURE_VERSION" default:"v4"` |
Contributor
There was a problem hiding this comment.
default value should be s3v4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhanced S3 Configuration Support
This update enhances the S3 storage configuration in the
internal/server/server.goandinternal/types/app/config.gofiles by introducing support for theS3SignatureVersionparameter. The changes include:S3SignatureVersionto theinitOSSfunction ininternal/server/server.goto pass the signature version configuration to the OSS setup.Configstruct ininternal/types/app/config.gowith a new fieldS3SignatureVersion string, defaulting to"v4", allowing flexible specification of the S3 signature version.These modifications enable better customization of S3 storage operations, providing support for different signature versions to enhance compatibility and flexibility.