refactor: remove catalog re-export modules#131
Merged
beinan merged 2 commits intolance-format:mainfrom Feb 12, 2026
Merged
Conversation
Remove redundant re-export modules (namespace/directory.rs and source_catalog.rs) and update all imports to use lance_graph_catalog directly. This addresses code review feedback from PR lance-format#130. Changes: - Remove crates/lance-graph/src/namespace/ directory - Remove crates/lance-graph/src/source_catalog.rs - Update lib.rs to re-export catalog types from lance_graph_catalog - Update all internal imports to use lance_graph_catalog - Update Python bindings to use new import paths Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
dcfocus
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses code review feedback from PR #130 by removing redundant re-export modules and updating imports to use
lance_graph_catalogdirectly.Changes
crates/lance-graph/src/namespace/directory (only contained re-exports)crates/lance-graph/src/source_catalog.rs(only contained re-exports)lib.rsto re-export catalog types directly fromlance_graph_cataloglance_graph_catalogTest plan
cargo check --allpassescargo test --allpasses (all 4 doc tests pass, all unit tests pass)Resolves review comments from #130
🤖 Generated with Claude Code