Skip to content

fix: make packed any size fallible #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lalinsky merged 1 commit into from
Apr 30, 2026
Merged

fix: make packed any size fallible #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 26 additions & 4 deletions src/any.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ const hdrs = @import("headers.zig");

const NonOptional = @import("utils.zig").NonOptional;

const getNullSize = @import("null.zig").getNullSize;
const packNull = @import("null.zig").packNull;
const unpackNull = @import("null.zig").unpackNull;

Expand Down Expand Up @@ -55,18 +56,25 @@ inline fn isString(comptime T: type) bool {
return false;
}

pub fn sizeOfPackedAny(comptime T: type, value: T) usize {
pub fn sizeOfPackedAny(comptime T: type, value: T) !usize {
if (@typeInfo(T) == .optional) {
if (value) |v| {
return sizeOfPackedAny(@TypeOf(v), v);
}
return getNullSize();
}

switch (@typeInfo(NonOptional(T))) {
.bool => return getBoolSize(),
.int => return getIntSize(T, value),
.float => return getFloatSize(T, value),
.@"enum" => return getEnumSize(T, value),
.pointer => |ptr_info| {
if (ptr_info.size == .Slice) {
if (ptr_info.size == .slice) {
if (isString(T)) {
return sizeOfPackedString(value.len);
return try sizeOfPackedString(value.len);
} else {
return sizeOfPackedArray(value.len);
return try sizeOfPackedArray(value.len);
}
}
},
Expand Down Expand Up @@ -376,3 +384,17 @@ test "packAny/unpackAny: Binary struct" {
defer std.testing.allocator.free(result.data);
try std.testing.expectEqualSlices(u8, "\x01\x02\x03\x04", result.data);
}

test "sizeOfPackedAny: string slice" {
try std.testing.expectEqual(4, try sizeOfPackedAny([]const u8, "abc"));
}

test "sizeOfPackedAny: array slice" {
const values = [_]u16{ 1, 2, 3 };
try std.testing.expectEqual(4, try sizeOfPackedAny([]const u16, &values));
}

test "sizeOfPackedAny: optional null and value" {
try std.testing.expectEqual(1, try sizeOfPackedAny(?[]const u8, null));
try std.testing.expectEqual(4, try sizeOfPackedAny(?[]const u8, "abc"));
}
Loading