refactor(BA-4080): add DB Source Pattern in User repository by MinJuTur · Pull Request #8455 · lablup/backend.ai

MinJuTur · 2026-01-30T05:17:49Z

Summary

Extract all DB session-opening logic from UserRepository into UserDBSource, following the established db_source pattern used across other repository domains
UserRepository now delegates pure DB methods to UserDBSource while retaining resilience decorators and orchestration logic
Mixed methods (delete_vfolders, delete_keypairs_with_valkey, _get_time_binned_monthly_stats) are restructured so that DB access is handled by UserDBSource with no behavioral changes

Related Issue

Jira: BA-4080

Test plan

pants check passes on all modified files
pants lint passes on all modified files
Existing unit tests pass (test_user_repository.py)

🤖 Generated with Claude Code

Copilot

Pull request overview

This PR refactors the UserRepository by extracting all DB session-opening logic into a new UserDBSource class, following the established db_source pattern used across other repository domains (e.g., AgentDBSource, ArtifactDBSource, DeploymentDBSource).

Changes:

Created UserDBSource class that handles all database operations with session management
UserRepository now delegates pure DB methods to UserDBSource while retaining resilience decorators
Test files updated to access internal methods through the new _db_source attribute

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

File	Description
`src/ai/backend/manager/repositories/user/repository.py`	Refactored to delegate DB operations to `UserDBSource`, keeping only orchestration logic and resilience decorators
`src/ai/backend/manager/repositories/user/db_source/db_source.py`	New file containing all DB session-opening logic and data access operations extracted from `UserRepository`
`src/ai/backend/manager/repositories/user/db_source/__init__.py`	New module initialization file exporting `UserDBSource`
`tests/unit/manager/repositories/user/test_user_repository.py`	Updated test calls to `_validate_user_access` to access it through `_db_source`

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

MinJuTur · 2026-01-30T05:42:46Z

+
+        return len(target_vfs)
+
+    async def delete_keypairs_with_valkey(


Similarly, this method takes ValkeyStatClient as a parameter because the original _delete_keypairs_with_valkey performed Valkey cleanup and DB deletion within a single transaction. Splitting them would change the transaction boundary — if Valkey cleanup fails, the DB transaction should roll back, which requires both operations to be in the same begin() scope.

MinJuTur · 2026-01-30T05:47:00Z

-            result = await conn.execute(query)
-            rows = result.fetchall()
+        # DB query via db_source
+        rows = await self._db_source.get_kernel_rows_for_monthly_stats(user_uuid)


Only the DB query part was extracted to db_source

Extract all DB session-opening logic from UserRepository into UserDBSource, following the established db_source pattern used in other repository domains. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

The `except VFolderOperationFailed: raise` block has no effect and can be safely removed along with its unused import. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

SQLAlchemy 2.0 properly infers scalar() return types, making explicit cast(Optional[str], result) redundant. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

The method always returns True and is never called in production code. Remove it along with the 3 associated test cases. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Remove cast(list[VFolderRow], ...) and cast(Optional[UUID], ...) that are no longer needed with SQLAlchemy 2.0 type inference. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

MinJuTur · 2026-02-02T04:33:01Z

+            await execute_batch_purger(session, create_user_error_log_purger(user_uuid))
+            await execute_batch_purger(session, create_user_keypair_purger(user_uuid))
+            await execute_batch_purger(session, create_user_vfolder_permission_purger(user_uuid))
+            await execute_batch_purger(session, create_user_group_association_purger(user_uuid))


Resolved merge conflict with purge_user from main, integrated into db_source pattern

jopemachine · 2026-02-02T05:06:40Z

Overall, there seems to be a lot of code that needs improvement, but it doesn’t seem appropriate to modify the existing code here.

Copilot AI review requested due to automatic review settings January 30, 2026 05:17

github-actions Bot assigned MinJuTur Jan 30, 2026

Copilot started reviewing on behalf of MinJuTur January 30, 2026 05:18 View session

MinJuTur added this to the 26.2 milestone Jan 30, 2026

MinJuTur added the Intern-OKR label Jan 30, 2026

Copilot AI reviewed Jan 30, 2026

View reviewed changes

Comment thread src/ai/backend/manager/repositories/user/db_source/db_source.py

MinJuTur commented Jan 30, 2026

View reviewed changes

Comment thread src/ai/backend/manager/repositories/user/db_source/db_source.py Outdated

MinJuTur commented Jan 30, 2026

View reviewed changes

Comment thread src/ai/backend/manager/repositories/user/db_source/db_source.py Outdated

MinJuTur commented Jan 30, 2026

View reviewed changes

Comment thread src/ai/backend/manager/repositories/user/db_source/db_source.py

MinJuTur commented Jan 30, 2026

View reviewed changes

MinJuTur requested review from HyeockJinKim and jopemachine January 30, 2026 05:47

jopemachine reviewed Jan 30, 2026

View reviewed changes

Comment thread tests/unit/manager/repositories/user/test_user_repository.py Outdated

jopemachine reviewed Jan 30, 2026

View reviewed changes

Comment thread src/ai/backend/manager/repositories/user/db_source/db_source.py Outdated

MinJuTur requested a review from jopemachine January 30, 2026 07:38

jopemachine reviewed Jan 30, 2026

View reviewed changes

Comment thread src/ai/backend/manager/repositories/user/db_source/db_source.py Outdated

MinJuTur requested a review from jopemachine February 2, 2026 04:12

MinJuTur and others added 6 commits February 2, 2026 04:17

refactor(BA-4080): Introduce db_source pattern in user repository

db8446a

Extract all DB session-opening logic from UserRepository into UserDBSource, following the established db_source pattern used in other repository domains. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

docs(BA-4080): Add changelog for user repository db_source pattern

581330e

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

refactor: remove unnecessary except-reraise in delete_vfolders

8153a43

The `except VFolderOperationFailed: raise` block has no effect and can be safely removed along with its unused import. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

refactor: remove unnecessary cast in domain/policy existence checks

4cd04b2

SQLAlchemy 2.0 properly infers scalar() return types, making explicit cast(Optional[str], result) redundant. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

refactor: remove dead code _validate_user_access and its tests

0656fcd

The method always returns True and is never called in production code. Remove it along with the 3 associated test cases. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

refactor: remove unnecessary casts in db_source

1135c84

Remove cast(list[VFolderRow], ...) and cast(Optional[UUID], ...) that are no longer needed with SQLAlchemy 2.0 type inference. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

MinJuTur force-pushed the refactor/BA-4080-introduce-db-source-pattern-in-user-repository branch from a454479 to 1135c84 Compare February 2, 2026 04:26

github-actions Bot added size:XL 500~ LoC comp:manager Related to Manager component labels Feb 2, 2026

MinJuTur commented Feb 2, 2026

View reviewed changes

jopemachine approved these changes Feb 2, 2026

View reviewed changes

jopemachine added this pull request to the merge queue Feb 2, 2026

Merged via the queue into main with commit b1df76b Feb 2, 2026
30 checks passed

jopemachine deleted the refactor/BA-4080-introduce-db-source-pattern-in-user-repository branch February 2, 2026 07:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(BA-4080): add DB Source Pattern in User repository#8455

refactor(BA-4080): add DB Source Pattern in User repository#8455
jopemachine merged 6 commits intomainfrom
refactor/BA-4080-introduce-db-source-pattern-in-user-repository

MinJuTur commented Jan 30, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MinJuTur Jan 30, 2026

Uh oh!

MinJuTur Jan 30, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MinJuTur Feb 2, 2026

Uh oh!

jopemachine commented Feb 2, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants


		return len(target_vfs)

		async def delete_keypairs_with_valkey(

Conversation

MinJuTur commented Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Related Issue

Test plan

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MinJuTur Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

MinJuTur Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MinJuTur Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

jopemachine commented Feb 2, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

MinJuTur commented Jan 30, 2026 •

edited

Loading