Skip to content

fix(FR-2977): open add-revision modal directly from revision history #7743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Jun 5, 2026
Merged

fix(FR-2977): open add-revision modal directly from revision history #7743

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 8 additions & 22 deletions react/src/components/DeploymentRevisionHistoryTab.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,15 +18,7 @@ import {
MoreOutlined,
PlayCircleOutlined,
} from '@ant-design/icons';
import {
App,
Dropdown,
Modal,
Popconfirm,
Space,
theme,
Typography,
} from 'antd';
import { App, Dropdown, Popconfirm, Space, theme, Typography } from 'antd';
import {
type BAIColumnType,
BAIButton,
Expand Down Expand Up @@ -750,19 +742,13 @@ const DeploymentRevisionHistoryTab: React.FC<
},
}}
/>
<Suspense
// Render a loading modal shell while the modal's lazy chunks resolve,
// so the trigger click is visually acknowledged instead of producing a
// momentary no-op.
fallback={
<Modal
open={!!sourceRevisionFrgmt}
loading
footer={null}
onCancel={() => setSourceRevisionFrgmt(null)}
/>
}
>
{/* Local Suspense around the lazily-mounted modal so its lazy form
selects (preset / vfolder / runtime variant `useLazyLoadQuery`)
don't bubble their suspend up to the page-level boundary and blank
the page. `fallback={null}` so the modal simply appears once ready,
instead of a loading-modal shell that then swaps for the real modal.
Mirrors `DeploymentDetailPage` / `VFolderNodesV2`. */}
<Suspense fallback={null}>
<BAIUnmountAfterClose>
<DeploymentAddRevisionModal
open={!!sourceRevisionFrgmt}
Expand Down
Loading