fix(FR-2977): move applying-revision alert inside current revision tab#7671
Merged
graphite-app[bot] merged 1 commit intoJun 5, 2026
Conversation
5 tasks
Contributor
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
4 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
Moves the “applying revision” (deploying different revision) informational alert so it only appears within the Current Revision tab of the deployment configuration UI.
Changes:
- Relocated the “ApplyingRevision”
<Alert>from outside the revision tab card into thecurrentRevisiontab content. - Added bottom spacing for the alert within the tab content to separate it from the revision detail view.
Contributor
Coverage Report for react-coverage (./react)
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
agatha197
changed the base branch from
05-27-refactor_fr-2977_unify_revision-source_prefill_in_deploymentaddrevisionmodal
to
graphite-base/7671
agatha197
force-pushed
the
06-01-fix_fr-2977_move_applying-revision_alert_inside_current_revision_tab
branch
from
ff0adee to
ec8fe86
Compare
agatha197
changed the base branch from
graphite-base/7671
to
05-22-feat_fr-2957_add_fork-from-here_action_in_revision_detail_drawer
agatha197
force-pushed
the
06-01-fix_fr-2977_move_applying-revision_alert_inside_current_revision_tab
branch
from
ec8fe86 to
34dda32
Compare
agatha197
force-pushed
the
06-01-fix_fr-2977_move_applying-revision_alert_inside_current_revision_tab
branch
4 times, most recently
from
dde3a60 to
5f5b340
Compare
agatha197
force-pushed
the
06-01-fix_fr-2977_move_applying-revision_alert_inside_current_revision_tab
branch
from
5f5b340 to
e331587
Compare
agatha197
changed the base branch from
05-22-feat_fr-2957_add_fork-from-here_action_in_revision_detail_drawer
to
graphite-base/7671
4 tasks
agatha197
force-pushed
the
graphite-base/7671
branch
from
bd7f09a to
ff479f8
Compare
agatha197
force-pushed
the
06-01-fix_fr-2977_move_applying-revision_alert_inside_current_revision_tab
branch
from
e331587 to
66562f7
Compare
agatha197
changed the base branch from
graphite-base/7671
to
05-22-feat_fr-2957_add_fork-from-here_action_in_revision_detail_drawer
Contributor
Coverage Report for backend-ai-ui-coverage (./packages/backend.ai-ui)
File Coverage
|
||||||||||||||||||||||||||||||||||||||
agatha197
force-pushed
the
05-22-feat_fr-2957_add_fork-from-here_action_in_revision_detail_drawer
branch
from
ff479f8 to
8c13610
Compare
agatha197
force-pushed
the
06-01-fix_fr-2977_move_applying-revision_alert_inside_current_revision_tab
branch
from
66562f7 to
09aff93
Compare
agatha197
force-pushed
the
05-22-feat_fr-2957_add_fork-from-here_action_in_revision_detail_drawer
branch
from
8c13610 to
c261498
Compare
agatha197
force-pushed
the
06-01-fix_fr-2977_move_applying-revision_alert_inside_current_revision_tab
branch
from
09aff93 to
fe2864b
Compare
agatha197
force-pushed
the
05-22-feat_fr-2957_add_fork-from-here_action_in_revision_detail_drawer
branch
from
c261498 to
600025e
Compare
agatha197
force-pushed
the
06-01-fix_fr-2977_move_applying-revision_alert_inside_current_revision_tab
branch
from
fe2864b to
65b2379
Compare
4 tasks
Merge activity
|
agatha197
changed the base branch from
05-22-feat_fr-2957_add_fork-from-here_action_in_revision_detail_drawer
to
graphite-base/7671
#7671) Resolves #7601 (FR-2977) > **Stacked on #7561 (FR-2957).** That PR adds the "Add new revision from this" entry, which is what surfaces the revision-detail drawer changes below. ## Summary Follow-up polish for FR-2977 after #7602 + #7561, focused on the deployment detail page's revision area. - **Move the "Applying revision #N" alert inside the Current Revision tab** (`DeploymentConfigurationSection`). Previously the alert sat at the deployment level between Basic Information and the revision tabs, so it was visible even on the Revision History tab where it had no context. It now lives inside the `currentRevision` tab content next to the revision detail it describes, with `marginBottom: token.marginMD` for separation from `DeploymentRevisionDetail`. - **Show the full revision UUID in `DeploymentRevisionDetail`.** The drawer/Current-Revision view rendered the 36-char revision ID inside a 2-column 183px cell, which truncated it to ~12 visible chars even with a copy button. Both `revision-number` and `revision-id` items now use `span: screens.md ? 2 : 1`, so each occupies a dedicated full-width row in the 2-column Descriptions. `BAIId` is rendered with `style={{ maxWidth: 'none' }}` so it sits at its natural width — the copy icon stays directly next to the UUID, and the `Current` / `Applying` `BAITag` follows immediately after in the same `BAIFlex`. - **Move the "Add Rules" button inline in `DeploymentAutoScalingTab`.** It used to live in the `BAICard extra` slot; it now sits inside `AutoScalingRuleList`'s toolbar to the right of the refresh button (the inline-add path the list already exposed via `hideInlineAddButton`). The card stops owning a primary button it didn't actually need. - **Misc.** Wrap `DeploymentAddRevisionModal` in a `<Suspense fallback={null}>` inside `DeploymentRevisionHistoryTab` so the row-level "Add new revision from this" action doesn't suspend the whole page on first open. ## Test plan - [x] Open a deployment with a deploying revision — verify the "Applying revision #N" alert appears inside the Current Revision tab (not above the tabs), and disappears when switching to Revision History. - [x] Open a revision via the Revision History row link — drawer shows `Revision Number` on one full-width row and `Revision ID <uuid> [copy] [Current|Applying]` on the next, full UUID visible, copy icon adjacent to the UUID. - [x] On the Current Revision tab — same layout; `Current` tag visible next to the copy icon. - [x] Auto-Scaling tab — "Add Rules" button sits to the right of the refresh button (inline), and is not duplicated in `BAICard extra`. - [x] `bash scripts/verify.sh` — TypeScript, Relay, Lint, Format all pass.
graphite-app
Bot
force-pushed
the
06-01-fix_fr-2977_move_applying-revision_alert_inside_current_revision_tab
branch
from
65b2379 to
5cd4f87
Compare
github-actions
Bot
added
area:ux
graphite-app
Bot
changed the base branch from
graphite-base/7671
to
05-22-feat_fr-2957_add_fork-from-here_action_in_revision_detail_drawer
Base automatically changed from
05-22-feat_fr-2957_add_fork-from-here_action_in_revision_detail_drawer
to
main
June 5, 2026 05:32
graphite-app
Bot
deleted the
06-01-fix_fr-2977_move_applying-revision_alert_inside_current_revision_tab
branch
graphite-app Bot
pushed a commit
that referenced
this pull request
Jun 5, 2026
#7724) Resolves #7601 (FR-2977) > **Stacked on #7671 (FR-2977).** That PR adds the "Add new revision from this" entry in the revision history row menu and the revision-detail drawer. This PR is a wording + icon polish on that same entry. ## Summary The revision-source action seeds a **new linear revision** pre-filled from an existing revision's configuration — it does **not** fork or duplicate the history (see #7671 / #7561, which deliberately avoided a branching icon). The previous copy ("Add new revision from this" / KO "이 리비전으로 추가") leaned on a "duplicate" framing that misreads the actual behavior and read inconsistently next to the in-modal **"Load current revision"** alert, whose own copy already frames loading a revision's settings as the *starting point* for a new revision. This PR aligns the entry with that "based on this / starting point" mental model: - **Reframe the action label** (`deployment.AddNewRevisionFromThis`) across all 21 locales: - EN: `Add new revision from this` → **`New revision based on this`** - KO: `이 리비전으로 추가` → **`이 리비전 기반으로 리비전 생성`** (noun-ending menu style, matching `리비전 보기` / `배포 삭제`; makes "creates a revision" explicit) - The other 19 locales are updated to the same "new revision based on this" framing, keeping each locale's established term for *revision* (es de-accented to `Revision` and ja switched to Latin-script `Revision` to match each locale's existing deployment strings). - **Switch the action icon** to lucide **`CopyPlus`** (`<CopyPlusIcon size={14} />`) in `DeploymentRevisionHistoryTab.tsx` — both entry points (the row overflow menu item and the drawer **More (⋯)** dropdown). It reads as "create a new revision from this one's settings" (copy **+** create new), distinct from the plain `Plus` used by the generic *Add Revision* button, without the fork/branch metaphor. ## Scope - Out of scope by design: the in-modal alert keys (`deployment.LoadCurrentRevision`, `deployment.CurrentRevisionAvailableDescription`, `deployment.CurrentRevisionConfigurationLoaded`) are **unchanged** — the alert already uses the correct "Load / starting point" vocabulary, and the new action label now reads coherently alongside it. - Pure copy + icon change. No behavioral or data-flow change. ## Test plan - [x] Revision History row ⋯ menu shows the new label with the CopyPlus icon, opens the Add Revision modal prefilled from that revision. - [x] Revision-detail drawer **More (⋯)** dropdown shows the same label + icon, same prefill behavior. - [x] In-modal "Load current revision" alert copy/behavior unchanged. - [x] `bash scripts/verify.sh` — Relay, Lint, Format, TypeScript all PASS.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #7601 (FR-2977)
Summary
Follow-up polish for FR-2977 after #7602 + #7561, focused on the deployment detail page's revision area.
DeploymentConfigurationSection). Previously the alert sat at the deployment level between Basic Information and the revision tabs, so it was visible even on the Revision History tab where it had no context. It now lives inside thecurrentRevisiontab content next to the revision detail it describes, withmarginBottom: token.marginMDfor separation fromDeploymentRevisionDetail.DeploymentRevisionDetail. The drawer/Current-Revision view rendered the 36-char revision ID inside a 2-column 183px cell, which truncated it to ~12 visible chars even with a copy button. Bothrevision-numberandrevision-iditems now usespan: screens.md ? 2 : 1, so each occupies a dedicated full-width row in the 2-column Descriptions.BAIIdis rendered withstyle={{ maxWidth: 'none' }}so it sits at its natural width — the copy icon stays directly next to the UUID, and theCurrent/ApplyingBAITagfollows immediately after in the sameBAIFlex.DeploymentAutoScalingTab. It used to live in theBAICard extraslot; it now sits insideAutoScalingRuleList's toolbar to the right of the refresh button (the inline-add path the list already exposed viahideInlineAddButton). The card stops owning a primary button it didn't actually need.DeploymentAddRevisionModalin a<Suspense fallback={null}>insideDeploymentRevisionHistoryTabso the row-level "Add new revision from this" action doesn't suspend the whole page on first open.Test plan
Revision Numberon one full-width row andRevision ID <uuid> [copy] [Current|Applying]on the next, full UUID visible, copy icon adjacent to the UUID.Currenttag visible next to the copy icon.BAICard extra.bash scripts/verify.sh— TypeScript, Relay, Lint, Format all pass.