Changing the Device in the UI doesn't change the device in the background#30
Open
uab2411 wants to merge 1 commit intolabbots:mainfrom
Open
Changing the Device in the UI doesn't change the device in the background#30uab2411 wants to merge 1 commit intolabbots:mainfrom
uab2411 wants to merge 1 commit intolabbots:mainfrom
Conversation
This comment was marked as duplicate.
This comment was marked as duplicate.
Avicennasis
added a commit
to Avicennasis/NiimPrintX
that referenced
this pull request
Apr 11, 2026
Changing the device in the GUI dropdown now actually updates config.device. Previously, the printer always connected as the initial default device. Upstream: labbots#30 by @uab2411 Partially addresses labbots#11, labbots#13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when changing devices in the UI, the device isn't actually changed everywhere in the code. Even after changing the device, I see an error that I am not able to connect to D110, even though I have chosen a different device. This small change fixes the issue