Fix risk check on monorepos#155
Closed
mlieberman85 wants to merge 1 commit intokusaridev:mainfrom
Closed
Conversation
Risk check was failing on monorepos because it was expecting each subproject to be its own individual git repo which is not usually the case. This change both fixes the issue and adds a --scan-subprojects flag for just concurrently scanning all subprojects. Ideally in the future we build a design that thinks of monorepos and subprojects as first class citizens.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Risk check was failing on monorepos because it was expecting each subproject to be its own individual git repo which is not usually the case.
This change both fixes the issue and adds a --scan-subprojects flag for just concurrently scanning all subprojects.
Ideally in the future we build a design that thinks of monorepos and subprojects as first class citizens.