feat(harness): integrate Antigravity agy CLI as verified crewmate/secondmate harness - #3524
Open
ashoffic wants to merge 5 commits into
Open
feat(harness): integrate Antigravity agy CLI as verified crewmate/secondmate harness#3524ashoffic wants to merge 5 commits into
ashoffic wants to merge 5 commits into
Conversation
Formally integrate the Antigravity agy CLI as a verified Firstmate crewmate and secondmate harness with: - Global plugin hook management via bin/fm-agy-turnend-hook.sh (PreInvocation and Stop) - Verified process detection, control capabilities, session lock identity, and quota-axi google provider mapping - Autonomous spawn template with --dangerously-skip-permissions, economic Gemini 3.7 Flash Medium default, and threaded --model/--effort flags - Teardown cleanup of task pointers, tokens, and registry auth records - Comprehensive unit, behavior, and integration tests in tests/fm-agy-harness.test.sh - Empirical verification documentation and harness reference docs
…ead spawn substitution
…dex for agy adapter
…comment, and turn-end guard docs for agy
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Reviews (2): Last reviewed commit: "no-mistakes(review): document the standi..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| muse) printf '%s' 'env -u CLAUDECODE -u PI_CODING_AGENT -u GROK_AGENT -u FM_PI_HARNESS -u ANTIGRAVITY_AGENT XDG_CONFIG_HOME=__MUSECONFIG__ XDG_DATA_HOME=__MUSEDATA__ MUSE_EXPERIMENTAL_FOREIGN_PERSONAL_CONTEXT_KILL=on __MUSEBIN__ --yolo __MODELFLAG____EFFORTFLAG__"$(__OPINPUT__ encode launch-brief < __BRIEF__)"' ;; | ||
| # Antigravity (agy): interactive supervised session launched with | ||
| # --dangerously-skip-permissions to run tool actions autonomously. | ||
| agy) printf '%s' 'env -u CLAUDECODE -u PI_CODING_AGENT -u GROK_AGENT -u FM_PI_HARNESS -u CURSOR_AGENT -u CURSOR_INVOKED_AS __AGYBIN__ --dangerously-skip-permissions __MODELFLAG____EFFORTFLAG__--prompt-interactive "$(__OPINPUT__ encode launch-brief < __BRIEF__)"' ;; |
There was a problem hiding this comment.
Every agy ship, scout, or secondmate launch includes --dangerously-skip-permissions, and the command reaches the worker pane without a later authority check. This disables tool-approval prompts without an explicit autonomy grant, allowing the worker to edit, commit, push, or perform other tool actions autonomously in its worktree.
Context Used: If there is a VISION.md file at the root of the re... (source)
Greptile flagged agy's unconditional --dangerously-skip-permissions as an autonomy bypass with no later authority check. Every verified harness (claude, codex, cursor, muse, grok) already composes the same kind of unconditional bypass flag in launch_template(): the explicit grant VISION.md requires is the captain's decision to spawn the task through fm-spawn.sh's task contract, not a second check inside the worker pane. Record that standing decision in .greptile/rules.md so it isn't re-litigated per harness. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Formally integrate the Antigravity agy CLI as a verified Firstmate crewmate and secondmate harness
What Changed
bin/fm-agy-turnend-hook.sh) and wiring through harness detection, spawn, control, teardown, busy, composer, and session-lock libraries (bin/fm-harness.sh,bin/fm-spawn.sh,bin/fm-control-lib.sh,bin/fm-teardown.sh, etc.) so agy can run as both a crewmate and secondmate.tests/fm-agy-harness.test.shand update existing harness tests (kimi, muse, quota-choose, secondmate) for the new adapter; add adapter reference docs (.agents/skills/harness-adapters/references/harness/agy.md,docs/verification/agy.md) and sync scripts inventory, resume-contract comments, turn-end guard docs, anddocs/documentation-audiences.json.Risk Assessment
✅ Low: The change adds the agy adapter by consistently extending every existing harness-dispatch table (control-lib, busy-lib, composer regexes, spawn templates, teardown cleanup, session-lock identity, quota provider mapping, docs) using the same patterns already established for grok/kimi/cursor, backed by a new comprehensive test suite (tests/fm-agy-harness.test.sh) and verification doc; the one prior-review commit already fixed the JSON-output trap bug, the orca C-u capability check, and a dead AGYBIN substitution, and a spot-check of the resulting backend-key refactor and hook script confirms they are correct.
Testing
All agy-adapter and related harness/secondmate test suites pass at the target commit; a full run of the pre-existing fm-secondmate-harness.test.sh suite (48/48) confirmed the branch's widened concurrency-test retry window fixes a real timing flake present at the base commit, with no regressions found across the CLI adapter integration.
Pipeline
Updates from git push no-mistakes
✅ **intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
✅ **Review** - passed
✅ No issues found.
✅ **Test** - passed
✅ No issues found.
bash tests/fm-agy-harness.test.shbash tests/fm-kimi-harness.test.shbash tests/fm-muse-harness.test.shbash tests/fm-quota-choose.test.shbash tests/fm-secondmate-harness.test.sh (target commit f830306, full run, 48/48 pass)bash tests/fm-secondmate-harness.test.sh (base commit 8988af2, full run in isolated clone, for flake comparison)✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.