Skip to content

feat(skills): react-only handling - #3466

Closed
austingmhuang wants to merge 2 commits into
kunchenguid:mainfrom
austingmhuang:fm/slack-react-only
Closed

feat(skills): react-only handling#3466
austingmhuang wants to merge 2 commits into
kunchenguid:mainfrom
austingmhuang:fm/slack-react-only

Conversation

@austingmhuang

@austingmhuang austingmhuang commented Sep 1, 2026

Copy link
Copy Markdown

asdf

Soran and Juan Miguel expect an emoji acknowledgement from the captain, not a
reply. The skill makes that explicit: two reactions, no text ever, and a
four-minute hold on the eyes reaction so it reads as a person opening the
message rather than an automated ack.

Also records the picker's space-separated emoji names, which do not match the
colon or hyphen forms and silently find nothing.
A skill nothing loads is dead weight, so the section 13 trigger and the
audience classification land with it.
@greptile-apps

greptile-apps Bot commented Sep 1, 2026

Copy link
Copy Markdown

Confidence Score: 3/5

This PR should not merge until the captain-specific policy is moved out of the shared template and the four-minute continuation uses a concrete supported scheduling mechanism.

The shared runtime unconditionally embeds one captain's colleague-specific preferences, and the required delayed reaction cannot be scheduled through the documented wake queue as instructed.

Files Needing Attention: .agents/skills/slack-react-only/SKILL.md and AGENTS.md

Reviews (1): Last reviewed commit: "docs: declare the slack-react-only load ..." | Re-trigger Greptile

Comment on lines +13 to +14

Soran and Juan Miguel are the only two people this covers.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Shared skill embeds personal policy

When another operator clones this shared template, the unconditional skill applies this captain's colleague-specific emoji-only policy to that operator's Slack contacts, causing legitimate messages from people with these names to be handled according to an unrelated personal preference. This conflicts with the requirement that shared surfaces remain generic and personal preferences stay private to the owning home.

Context Used: If there is a VISION.md file at the root of the re... (source)

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Comment on lines +61 to +62
The colon form (`:thumbsupparrot:`) and the hyphen form match nothing in the picker.
The label is on the gridcell's child button, not on the gridcell itself.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Delayed reaction lacks scheduling mechanism

When a qualifying request arrives before its four-minute hold has elapsed, this instruction delegates the continuation to a wake even though the documented wake queue only records immediate events at the current epoch. The required reaction therefore cannot be scheduled through that queue as instructed, causing it to be sent immediately or never delivered.

@austingmhuang austingmhuang changed the title feat(skills): react-only handling of Soran and Juan Miguel messages feat(skills): react-only handling Sep 2, 2026
@austingmhuang
austingmhuang deleted the fm/slack-react-only branch September 2, 2026 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant