[Addon] velaux: environment variables support#784
Draft
pray wants to merge 4 commits intokubevela:masterfrom
Draft
[Addon] velaux: environment variables support#784pray wants to merge 4 commits intokubevela:masterfrom
pray wants to merge 4 commits intokubevela:masterfrom
Conversation
Signed-off-by: Prayana Galih <prayana.galih@gmail.com>
Signed-off-by: Prayana Galih <prayana.galih@gmail.com>
Signed-off-by: Prayana Galih <prayana.galih@gmail.com>
Signed-off-by: Prayana Galih <prayana.galih@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Adding environment variables support to velaux addon, using partial coverage of Kubernetes pod spec's EnvVar.
The only way to set database connection in velaux addon is via
parameter.dbURL, in plain text.Because
parameter.dbURLwill be passed as part ofcmdin Kubernetes pod spec, it can use variable substitutions$(VAR). Those variables can refer to separately managed resources (secrets and/or config map). By allowing environment variables to be set, we can avoid putting sensitive information inparameter.dbURL.Bumped version to 1.9.5. There happen to be a 1.9.5 in velaux releases.
How has this code been tested?
On kubevela core version 1.10.6
Tested by enabling the addon without
envparameter (existing capability), and upgrading withenv:Checklist
I have:
[Addon],[example]or[Doc]).versioninmetadata.yamlto generate a new version.Verified Addon promotion rules
If this pr wants to promote an experimental addon to verified, you must check whether meet these conditions too:
metadata.yaml.README.md.Summary by cubic
Add env[] support to the velaux addon so you can inject ConfigMap/Secret-based environment variables into the server pod. This enables $(VAR) substitution in dbURL to avoid hardcoded credentials.
New Features
Migration
Written for commit 4f9c01d. Summary will update on new commits.