-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat(backend): double input size limit. Fixes #12510 #12519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat(backend): double input size limit. Fixes #12510 #12519
Conversation
…beflow#4828, fixes kubeflow#12510. Signed-off-by: feiyuzhang <[email protected]>
|
Hi @neo99zhang. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
chensun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
/ok-to-test |
|
New changes are detected. LGTM label has been removed. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/ok-to-test |
|
/retest |
Description of your changes:
This PR increases the maximum parameter size limit from 10KB to 20KB by doubling
MaxParameterBytesfrom10000 to 20000.
Motivation
Fixes #2286, fixes #4828, fixes #12510
Users need to pass larger parameter values to their pipelines. The current 10KB limit is too restrictive
for complex parameter configurations.
Test Results:
✅ Parameter validation tests - PASSED (2/2)
✅ Util package tests - PASSED (all 59 tests)
✅ Apiserver package tests - PASSED (all 385 tests)
✅ Backend build - SUCCESS
Checklist:
@HumairAK @chensun Thanks for your time and attention