Skip to content

Conversation

@neo99zhang
Copy link

@neo99zhang neo99zhang commented Dec 3, 2025

Description of your changes:
This PR increases the maximum parameter size limit from 10KB to 20KB by doubling MaxParameterBytes from
10000 to 20000.

Motivation

Fixes #2286, fixes #4828, fixes #12510

Users need to pass larger parameter values to their pipelines. The current 10KB limit is too restrictive
for complex parameter configurations.

Test Results:

✅ Parameter validation tests - PASSED (2/2)

  • TestValidatePipelineSpecAndResourceReferences_ParameterTooLongWithPipelineId
  • TestValidatePipelineSpecAndResourceReferences_ParameterTooLongWithWorkflowManifest

✅ Util package tests - PASSED (all 59 tests)

✅ Apiserver package tests - PASSED (all 385 tests)

✅ Backend build - SUCCESS

Checklist:

@HumairAK @chensun Thanks for your time and attention

@google-oss-prow
Copy link

Hi @neo99zhang. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@chensun chensun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@chensun
Copy link
Member

chensun commented Dec 4, 2025

/ok-to-test

@google-oss-prow google-oss-prow bot removed the lgtm label Dec 4, 2025
@google-oss-prow
Copy link

New changes are detected. LGTM label has been removed.

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from chensun. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hbelmiro
Copy link
Contributor

hbelmiro commented Dec 4, 2025

/ok-to-test

@hbelmiro
Copy link
Contributor

hbelmiro commented Dec 4, 2025

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feature] Increase input parameter size limitation Increase input parameter length limitation Increase pipeline input argument length/size

3 participants