feat(frontend): use notebook name as default pipeline name and handle TaskMissingError #524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced TaskMissingError to signal when a pipeline lacks steps. - Updated the compiler to raise TaskMissingError if no steps are present. - Mapped TaskMissingError to RPCTaskIsMissing for RPC error handling. - Enhanced error handling in the notebook compilation process to provide user guidance for missing steps. - Added utility functions in the UI to display informative dialogs for missing pipeline steps.
StefanoFioravanzo
changed the title
Member
|
@cordeirops I took the liberty of updating the PR title and adding the issue link to the end of the firsts comment - in that way the PR and issue are linked |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: use notebook name as default pipeline name and handle TaskMissingError
Summary
This PR introduces improvements to pipeline name generation and error handling during notebook compilation.
Key Changes
pipeline_name, applying sanitization to comply with KFP naming rules.TaskMissingError, raised by the compiler when a pipeline contains no steps.TaskMissingErrortoRPCTaskIsMissingat the RPC layer and return a more actionabledetailsmessage to the client.7(TaskIsMissing).Fixes #510