KTOR-9355 Deprecate HttpHeaders.AcceptCharset#5411
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (9)
WalkthroughThis PR deprecates the Accept-Charset HTTP header constant across the Ktor framework and adds Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
osipxd
commented
Mar 2, 2026
| * [Report a problem](https://ktor.io/feedback/?fqname=io.ktor.server.request.acceptCharsetItems) | ||
| */ | ||
| @Suppress("DEPRECATION") | ||
| public fun ApplicationRequest.acceptCharsetItems(): List<HeaderValue> = |
Member
Author
There was a problem hiding this comment.
Should we also deprecate these functions? My thought was that we should discourage users from adding this header, but it's okay to try to read it, because server is usually out of control.
Contributor
There was a problem hiding this comment.
I think reading it in is fine, maybe exclude this one.
bjhham
reviewed
Mar 19, 2026
Contributor
bjhham
left a comment
bjhham
left a comment
There was a problem hiding this comment.
Could you include some KDoc or a deprecation message that either references or summarizes the reason in the RFC note?
| * [Report a problem](https://ktor.io/feedback/?fqname=io.ktor.server.request.acceptCharsetItems) | ||
| */ | ||
| @Suppress("DEPRECATION") | ||
| public fun ApplicationRequest.acceptCharsetItems(): List<HeaderValue> = |
Contributor
There was a problem hiding this comment.
I think reading it in is fine, maybe exclude this one.
osipxd
commented
Apr 2, 2026
Comment on lines
+21
to
25
| @Deprecated( | ||
| "The Accept-Charset request header has been deprecated in RFC 9110. " + | ||
| "UTF-8 should be used by default in modern applications." | ||
| ) | ||
| public const val AcceptCharset: String = "Accept-Charset" |
Member
Author
There was a problem hiding this comment.
@bjhham, could you check if this deprecation message is enough?
bjhham
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subsystem
ktor-httpMotivation
KTOR-9355 Deprecate HttpHeaders.AcceptCharset