Derive LSP distribution id from package.json name#388
Open
holodorum wants to merge 1 commit into
Open
Conversation
The VSCode extension hard-coded "kson" as the prefix for its command ids, configuration section, and diagnostic source — duplicating `name`, which the manifest already has to declare and which VSCode guarantees unique per publisher. Read it from `packageJSON.name` and thread it as `distributionId` through the LSP init options, so the manifest's contribution keys and the runtime namespace can't drift apart. `KsonSettings` is unwrapped in the same pass — the server now strips the outer namespace key, so the type is `{ formatOptions, codeLensEnabled }` instead of `{ kson: {...} }`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The VSCode extension hard-coded "kson" as the prefix for its command ids, configuration section, and diagnostic source — duplicating
name, which the manifest already has to declare and which VSCode guarantees unique per publisher. Read it frompackageJSON.nameand thread it asdistributionIdthrough the LSP init options, so the manifest's contribution keys and the runtime namespace can't drift apart.KsonSettingsis unwrapped in the same pass—the server now strips the outer namespace key, so the type is{ formatOptions, codeLensEnabled }instead of{ kson: {...} }.