✨ add support for arm architectures - #241
Open
a-tokyo wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description: PR adds automatic ARM64 architecture detection and support to the action, allowing it to work seamlessly on both x64 and ARM64 GitHub Actions runners.
Changes
Core Changes
Added
getPlatformSuffix()function insrc/main.tsto detect platform and architecturearm64,aarch64)-arm64suffix)Updated
install()function to use the new platform suffix when constructing download URLscopilot-linux-v1.33.0copilot-linux-arm64-v1.33.0Documentation Changes
action.yml: Addedversioninput parameter with descriptionREADME.md:Build
npm run allTesting
Build & Tests
npm run build # ✅ TypeScript compilation successful
npm run package # ✅ Bundle created successfully
npm test # ✅ All tests passing### Compatibility
ubuntu-latest-arm64)Example Usage
Before (ARM64 users had to do this manually):
run: |
curl --proto '=https' -Lo /tmp/copilot-cli https://github.com/aws/copilot-cli/releases/latest/download/copilot-linux-arm64
chmod +x /tmp/copilot-cli
sudo mv /tmp/copilot-cli /usr/local/bin/copilot### After (works automatically on both x64 and ARM64):
uses: ksivamuthu/aws-copilot-github-action@main
with:
command: install## Checklist
Source code updated (
src/main.ts)Built and packaged (
dist/index.js)Documentation updated (
README.md,action.yml)Tests passing
No breaking changes
Backwards compatible
Related Issues
Closes #240