ci: take release notes from the repository instead of the workflow - #52
Merged
Conversation
The "What's Changed" and "Validation" prose was hardcoded in release.yml, so every release republished 11.1.0's notes regardless of what actually changed. The twin Notepad++ repository had the same defect and shipped stale notes with its 11.2.0 release. The prose now lives in docs/release-notes.md, rewritten in the same commit that bumps VERSION, and the release job appends it to the generated Builds / Downloads block. The job gains a sparse checkout of just that file - it checked out nothing before - and fails if the file is missing or empty rather than publishing a release without notes.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
krotname
enabled auto-merge (squash)
September 6, 2026 05:52
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same defect as krotname/NppMarkdownTableEditor#33, in this repository's
release.yml: the "What's Changed" and "Validation" prose is hardcoded in a heredoc, so every release republishes 11.1.0's notes no matter what changed. The twin repository actually shipped stale notes with its 11.2.0 release; here the 11.2.0 notes were written by hand at publish time, so nothing wrong reached the public release.The prose now lives in
docs/release-notes.md, to be rewritten in the same commit that bumpsVERSION. The release job appends everything from that file's first##heading onward to the generatedBuilds / Downloadsblock, and fails when the file is missing or empty. The job gains a sparse checkout of just that one file - it checked out nothing before.Separate, not fixed here
The
buildjob requiresruns-on: [self-hosted, windows, adler-lenovo], and this repository has no registered self-hosted runner, so the release workflow's build job sits queued forever - that is why v11.2.0 had to be built and published manually from a localgradlew buildPlugin+verifyPluginrun. Deciding between registering the runner again and moving the job towindows-latestis a separate call.