Skip to content

Conversation

@standortdigital
Copy link

Fix for call and video

Thank you so much for your contribution to FluffyChat ❤️❤️❤️

Please make sure that your Pull Request meet the following acceptance criteria:

  • Code formatting and import sorting has been done with dart format lib/ test/ and dart run import_sorter:main --no-comments
  • The commit message uses the format of Conventional Commits
  • The commit message describes what has been changed, why it has been changed and how it has been changed
  • Every new feature or change of the design/GUI is linked to an approved design proposal in an issue
  • Every new feature in the app or the build system has a strategy how this will be tested and maintained from now on for every release, e.g. a volunteer who takes over maintainership

Pull Request has been tested on:

  • [x ] Android
  • [x ] iOS
  • Browser (Chromium based)
  • Browser (Firefox based)
  • Browser (WebKit based)
  • Desktop Linux
  • Desktop Windows
  • Desktop macOS

Fix for call and video
@summer513
Copy link

I am really looking forward to this update

@Hazematman
Copy link

Hey I'm not a fluffychat maintainer, but I would really like to see VoIP working as fluffychat seems to be a more friendly client. I took a look at your PR and its hard to review since you pushed your changes with windows line endings. You should configure your client to convert them to unix line endings like the file is already by running the command

git config --global core.autocrlf input

This will configure git on your system to checkout the code as-is but when you make a commit it will convert to unix line endings.

I modified your PR here to have unix line endings and to make things easier to review. main...Hazematman:fluffychat:review/voip_fix

I'm not really a flutter developer but right of the bat one thing I noticed is that you added random white space in some places that didn't exist before. I would probably clean that up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants