fix: don't let the default timeout kill streamed downloads - #28
Merged
Conversation
http.Client.Timeout covers reading the entire response body, so a streamed transfer (-o FILE or piped stdout, both via BodySink) was killed at the 30s default mid-download — defeating the point of the streaming path, which exists for arbitrarily large bodies. Do() now executes BodySink requests on a second client whose transport bounds the wait for response headers (ResponseHeaderTimeout) instead of the whole transfer, cloned from the default transport so the 30s dial timeout still applies. An explicit --timeout remains a total cap, also for streams: runCLI/runTUI now set it via Client.SetTimeout, which records that the user asked for one. Buffered requests are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
http.Client.Timeout covers reading the entire response body, so a streamed transfer (-o FILE or piped stdout, both via BodySink) was killed at the 30s default mid-download — defeating the point of the streaming path, which exists for arbitrarily large bodies.
Do() now executes BodySink requests on a second client whose transport bounds the wait for response headers (ResponseHeaderTimeout) instead of the whole transfer, cloned from the default transport so the 30s dial timeout still applies. An explicit --timeout remains a total cap, also for streams: runCLI/runTUI now set it via Client.SetTimeout, which records that the user asked for one. Buffered requests are unchanged.