chore(ci): bump pinned GitHub Actions SHAs to latest releases - #26
Merged
Merged
Conversation
Signed-off-by: Jonathon Klobucar <jonathon.klobucar@gmail.com>
Signed-off-by: Jonathon Klobucar <jonathon.klobucar@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Bumps the pinned commit SHAs for 7 GitHub Actions to their latest releases, and adds
.github/workflows/codeql.yml(an existing untracked file in the working tree, now updated to the same SHAs and brought into version control).Why
Keeps CI on current action releases rather than stale training-data-era pins. Four are major-version bumps:
actions/checkoutv6→v7,actions/cachev5→v6,github/codeql-actionv3→v4,actions/setup-dotnetv5→v6.How tested
No Rust source changed in this branch, so
cargo fmt/clippy/testaren't meaningfully exercised — this is CI-config only. Verified instead:/commits/{tag}), notgit ls-remote— the latter returned unpeeled annotated-tag SHAs forcodeql-actionandcommitlint-github-actionthat would've mispinned them.actionlinton all changed workflow files: clean except one pre-existing shellcheck style nit inmacos.yml(unrelated to this change).uvx zizmoragainstcodeql.ymlwith the repo's.github/zizmor.ymlconfig: no findings in the default persona (what CI'szizmor.ymlworkflow actually runs); pedantic persona surfaces 9 pre-existing informational/low nits (template-injection on env-var interpolation, undocumented job permissions, superfluousdtolnay/rust-toolchain), none introduced by this change and none blocking.codeql.yml'sOPUS_MODEL_CHECKSUM/UNIFFI_BINDGEN_CS_TAGenv values and the cron-offset comment againstci.yml/macos.yml/desktop.yml/security.yml— all consistent.Notes for the reviewer
The
codeql-actionv3→v4 bump in particular I couldn't exercise end-to-end (can't run GitHub-hosted Actions locally) — worth watching that job on this PR's own CI run. Wasn't able to runzizmor's online audits (need aGH_TOKEN, not available locally) — CI'szizmor.ymljob does haveactions: readand will run those.Checklist
git commit -s) per the DCOcargo fmt --allclean — n/a, no Rust files changedcargo clippy --workspace --all-targets -- -D warningsclean — n/a, no Rust files changedcargo test --workspacepasses — n/a, no Rust files changeddocs/protocol.md— n/a, no wire changesdocs/MLS_SECURITY.mdordocs/05_dave_protocol_deviations.md— n/a, no crypto changes