feat: wire channel deletion to server handler & expose audio processing toggles - #11
Merged
Merged
Conversation
The admin Delete Channel button was a dead TODO. Send MSG_DELETE_CHANNEL (0x43) from a new deleteChannel(id:); the server handler and post-delete snapshot broadcast already exist, so the channel list refreshes for everyone. Guarded by a destructive confirmation dialog to prevent one-click deletes.
Surface echo cancellation, WebRTC noise suppression, and automatic gain control in Audio Settings, matching the desktop client. They post the keys applyAudioSettings already handles and that the connect-time path reads from UserDefaults, so changes apply live and persist across restarts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Why
How tested
Notes for the reviewer
Checklist
git commit -s) per the DCOcargo fmt --allcleancargo clippy --workspace --all-targets -- -D warningscleancargo test --workspacepassesdocs/protocol.mddocs/MLS_SECURITY.mdordocs/05_dave_protocol_deviations.md