feat(helm): add values comparison for install, upgrade and release detail - #662
Open
yupanzi wants to merge 1 commit into
Open
feat(helm): add values comparison for install, upgrade and release detail#662yupanzi wants to merge 1 commit into
yupanzi wants to merge 1 commit into
Conversation
…tail Add a monaco-based diff view (kubeapps-style) so value changes can be reviewed before they are applied: - helm-install-dialog: compare the edited values against the chart's package defaults or, on upgrade, the currently deployed values, with side-by-side / inline and highlight-changes toggles - helmrelease-detail: view and compare deployed values across revisions - helm-values: shared normalization helpers with unit tests - sort chart versions by semver (publish time only as tie-breaker) so the upgrade dropdown is ordered correctly for repackaged indexes - expose window.monaco so e2e specs can drive the diff editors, and extend the helm e2e spec to cover the comparison flow Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a values comparison view for Helm install, upgrade, and release detail:
window.monacois exposed so tests can drive the editors, matching what the AMD build already did.yamlruntime dependency for values normalization.Why
When installing or upgrading a chart it is easy to lose track of what actually changed in the values, especially on upgrades where the edited values drift from both the chart defaults and what is currently deployed. Kubeapps solves this with a values diff view; this PR brings the same idea to Kite.
Related issue
Closes #667
Validation
go test ./pkg/helm/...(newcontent_test.gocovers the version ordering)pnpm run type-check && pnpm run lint && pnpm run test(newhelm-values.test.ts)make e2e-run SPEC=specs/helm-kite.spec.tsflow extended for the diff viewChecklist
🤖 Generated with Claude Code