Skip to content
This repository was archived by the owner on May 14, 2021. It is now read-only.

add whitelist support to load testing#15

Open
oryband wants to merge 28 commits intomasterfrom
whitelist
Open

add whitelist support to load testing#15
oryband wants to merge 28 commits intomasterfrom
whitelist

Conversation

@oryband
Copy link
Copy Markdown
Contributor

@oryband oryband commented Aug 21, 2019

also:

  • adapt test enviornment and automation scripts for new whitelist load test feature
  • migrate from glide to go dep
  • migrate from stellar/go to kinecosystem/go and pin version
  • minor documentation and cosmetic code updates

@avi-kik
Copy link
Copy Markdown
Contributor

avi-kik commented Aug 21, 2019

I don't understand the whitelist command. What is it for?

@oryband
Copy link
Copy Markdown
Contributor Author

oryband commented Aug 21, 2019

I don't understand the whitelist command. What is it for?

@avi-kik it adds an address to the whitelist. It is meant to be run once per test as part of the setup, before we start the load test app, just like we create test accounts before starting the load test app.

@avi-kik
Copy link
Copy Markdown
Contributor

avi-kik commented Aug 21, 2019

Such a command is not necessary for testing.

  1. the whitelist account holder (configured in stellar-core.cfg) is a whitelisted account.
  2. the whitelist account holder doesn't need to exist on the blockchain. It works by virtue of being defined as the holder.

@oryband
Copy link
Copy Markdown
Contributor Author

oryband commented Aug 21, 2019

@avi-kik this app doesn't create account at all, it just adds a list of addresses to the whitelist. It lets you control which addresses are whitelisted or not.

@avi-kik
Copy link
Copy Markdown
Contributor

avi-kik commented Aug 21, 2019

This will be useful when we have multi-level priority whitelisting, but at the moment, this is not needed for running tests.

@oryband oryband force-pushed the whitelist branch 4 times, most recently from 5d56d55 to 1d40f7e Compare August 25, 2019 11:47
also create whitelist only if it doesn't exist
also some other cosmetic updates to cmd/python/prepare_accounts.sh
@oryband oryband force-pushed the whitelist branch 3 times, most recently from dc0e0ea to 6a0a24e Compare August 25, 2019 14:43
@avi-kik
Copy link
Copy Markdown
Contributor

avi-kik commented Aug 27, 2019

The make vendor command is broken if you don't have dep installed in the local directory, and there's no script or instructions for downloading it.

@oryband
Copy link
Copy Markdown
Contributor Author

oryband commented Aug 27, 2019

The make vendor command is broken if you don't have dep installed in the local directory, and there's no script or instructions for downloading it.

@avi-kik it's standard go toolchain utility and i thought it's out of the scope of this repo, similar to not having instructions to install pip in a python repo or npm in a node repo. regardless checkout the (very short) docs https://golang.github.io/dep/

@oryband
Copy link
Copy Markdown
Contributor Author

oryband commented Aug 27, 2019

@avi-kik can you add a review for this PR please?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants