Conversation
…stem/blockchain-load-testing
because 2019
…instead of stellar
app receives whitelist account seed and a list of addresses, and adds these addresses to the whitelist
|
I don't understand the whitelist command. What is it for? |
@avi-kik it adds an address to the whitelist. It is meant to be run once per test as part of the setup, before we start the load test app, just like we create test accounts before starting the load test app. |
|
Such a command is not necessary for testing.
|
|
@avi-kik this app doesn't create account at all, it just adds a list of addresses to the whitelist. It lets you control which addresses are whitelisted or not. |
|
This will be useful when we have multi-level priority whitelisting, but at the moment, this is not needed for running tests. |
5d56d55 to
1d40f7e
Compare
also create whitelist only if it doesn't exist also some other cosmetic updates to cmd/python/prepare_accounts.sh
dc0e0ea to
6a0a24e
Compare
|
The |
@avi-kik it's standard go toolchain utility and i thought it's out of the scope of this repo, similar to not having instructions to install pip in a python repo or npm in a node repo. regardless checkout the (very short) docs https://golang.github.io/dep/ |
|
@avi-kik can you add a review for this PR please? |
…argument until now it didn't, resulting in a bug where the whitelisting feature wasn't used
also: